Bug 156158

Summary: [TexMap] resolveOverlaps() should be passed-in the first Region parameter via a reference
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, commit-queue, kondapallykalyan, luiz, noam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch tonikitoo: review+

Zan Dobersek
Reported 2016-04-04 01:24:18 PDT
[TexMap] resolveOverlaps() should be passed-in the first Region parameter via a reference
Attachments
Patch (1.82 KB, patch)
2016-04-04 01:29 PDT, Zan Dobersek 		tonikitoo: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2016-04-04 01:29:03 PDT
Created attachment 275535 [details] Patch
Antonio Gomes
Comment 2 2016-04-04 07:03:36 PDT
Comment on attachment 275535 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=275535&action=review > Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp:241 > +static void resolveOverlaps(Region& newRegion, Region& overlapRegion, Region& nonOverlapRegion) It does not look like the modified 'newRegion' value is used in the callee site, but it avoid one copy, ok.
Zan Dobersek
Comment 3 2016-04-04 23:09:06 PDT
Committed r199044: <http://trac.webkit.org/changeset/199044>
Note You need to log in before you can comment on or make changes to this bug.