Bug 156158

Summary: [TexMap] resolveOverlaps() should be passed-in the first Region parameter via a reference
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, commit-queue, kondapallykalyan, luiz, noam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch tonikitoo: review+

Description Zan Dobersek 2016-04-04 01:24:18 PDT
[TexMap] resolveOverlaps() should be passed-in the first Region parameter via a reference
Comment 1 Zan Dobersek 2016-04-04 01:29:03 PDT
Created attachment 275535 [details]
Patch
Comment 2 Antonio Gomes 2016-04-04 07:03:36 PDT
Comment on attachment 275535 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=275535&action=review

> Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp:241
> +static void resolveOverlaps(Region& newRegion, Region& overlapRegion, Region& nonOverlapRegion)

It does not look like the modified 'newRegion' value is used in the callee site, but it avoid one copy, ok.
Comment 3 Zan Dobersek 2016-04-04 23:09:06 PDT
Committed r199044: <http://trac.webkit.org/changeset/199044>