Bug 156156

Summary: Enable assertions against DOM mutations in RenderTreeUpdater
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
kling: review+
patch
none
patch none

Antti Koivisto
Reported 2016-04-04 00:10:48 PDT
Ensure we don't mutate DOM or dispatch events during render tree updates.
Attachments
patch (16.29 KB, patch)
2016-04-04 01:12 PDT, Antti Koivisto 		kling: review+
DetailsFormatted DiffDiff
patch (16.49 KB, patch)
2016-04-04 01:22 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (16.53 KB, patch)
2016-04-04 01:51 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2016-04-04 01:12:08 PDT
Created attachment 275532 [details] patch
Andreas Kling
Comment 2 2016-04-04 01:19:46 PDT
Comment on attachment 275532 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=275532&action=review r=me > Source/WebCore/loader/cache/CachedSVGFont.cpp:69 > + auto count = NoEventDispatchAssertion::dropTemporarily(); If we plan to do more of this, maybe a RAII helper would be in good taste.
Antti Koivisto
Comment 3 2016-04-04 01:22:23 PDT
Created attachment 275534 [details] patch
Antti Koivisto
Comment 4 2016-04-04 01:51:13 PDT
Created attachment 275537 [details] patch
Antti Koivisto
Comment 5 2016-04-04 06:09:29 PDT
https://trac.webkit.org/r199003
Note You need to log in before you can comment on or make changes to this bug.