Bug 156156

Summary:

Enable assertions against DOM mutations in RenderTreeUpdater

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

DOM

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	kling: review+
patch	none
patch	none

Description Antti Koivisto 2016-04-04 00:10:48 PDT

Ensure we don't mutate DOM or dispatch events during render tree updates.

Comment 1 Antti Koivisto 2016-04-04 01:12:08 PDT

Created attachment 275532 [details]
patch

Comment 2 Andreas Kling 2016-04-04 01:19:46 PDT

Comment on attachment 275532 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=275532&action=review

r=me

> Source/WebCore/loader/cache/CachedSVGFont.cpp:69
> +        auto count = NoEventDispatchAssertion::dropTemporarily();

If we plan to do more of this, maybe a RAII helper would be in good taste.

Comment 3 Antti Koivisto 2016-04-04 01:22:23 PDT

Created attachment 275534 [details]
patch

Comment 4 Antti Koivisto 2016-04-04 01:51:13 PDT

Created attachment 275537 [details]
patch

Comment 5 Antti Koivisto 2016-04-04 06:09:29 PDT

https://trac.webkit.org/r199003