Bug 156151

Summary: prepare-ChangeLog set endl incorrectly
Product: WebKit Reporter: Bill Ming <mbbill>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, lforschler
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Bill Ming 2016-04-03 17:06:41 PDT
prepare-Changelog tried to detect line endings based on the target file format, normally the ChangeLog file is in unix ('\n') line endings, and the perl script will prepare content with each line appended with a '\n', but when writing to the file, perl will try to convert line endings with the platform's native line endings and result in changing the whole file into dos format.
setting the binmode can fix this issue.
Comment 1 Bill Ming 2016-04-03 17:09:26 PDT
Created attachment 275518 [details]
Patch
Comment 2 WebKit Commit Bot 2016-04-04 15:54:26 PDT
Comment on attachment 275518 [details]
Patch

Clearing flags on attachment: 275518

Committed r199029: <http://trac.webkit.org/changeset/199029>
Comment 3 WebKit Commit Bot 2016-04-04 15:54:30 PDT
All reviewed patches have been landed.  Closing bug.