Bug 15615

Summary:

[GTK] Work towards -Werror, -Wall

Product:

WebKit

Reporter:

Alp Toker <alp>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Keywords:

Cairo, Gtk

Priority:

Version:

523.x (Safari 3)

Hardware:

OS:

All

Attachments:

Description	Flags
Holger's (now obsoleted but still useful) warning fixes	none
Use -Wall, add DirectFB build support	alp: review+

Alp Toker

Reported 2007-10-22 05:57:58 PDT

Eliminating warnings can help fix real bugs. Whether we actually want -Werror, -Wall on the default Release build is still up for debate. There are arguments for and against, though I am tending towards the former.

Attachments
Holger's (now obsoleted but still useful) warning fixes (12.50 KB, patch) 2007-10-22 05:59 PDT, Alp Toker	no flags	Details Formatted Diff Diff
Use -Wall, add DirectFB build support (1.82 KB, patch) 2007-11-20 07:14 PST, Alp Toker	alp: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Alp Toker

Comment 1 2007-10-22 05:59:48 PDT

Created attachment 16792 [details] Holger's (now obsoleted but still useful) warning fixes Many of these have been fixed. Some have not. Patch by Holger Freyther.

Alp Toker

Comment 2 2007-11-20 07:14:51 PST

Created attachment 17417 [details] Use -Wall, add DirectFB build support

Alp Toker

Comment 3 2007-11-20 07:53:48 PST

Comment on attachment 17417 [details] Use -Wall, add DirectFB build support Reviewed by Simon (whose Bugzilla account is broken). Landed in r27926.

Note You need to log in before you can comment on or make changes to this bug.