Bug 15615

Summary:

[GTK] Work towards -Werror, -Wall

Product:

WebKit

Reporter:

Alp Toker <alp>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Keywords:

Cairo, Gtk

Priority:

Version:

523.x (Safari 3)

Hardware:

OS:

All

Attachments:

Description	Flags
Holger's (now obsoleted but still useful) warning fixes	none
Use -Wall, add DirectFB build support	alp: review+

Description Alp Toker 2007-10-22 05:57:58 PDT

Eliminating warnings can help fix real bugs.

Whether we actually want -Werror, -Wall on the default Release build is still up for debate. There are arguments for and against, though I am tending towards the former.

Comment 1 Alp Toker 2007-10-22 05:59:48 PDT

Created attachment 16792 [details]
Holger's (now obsoleted but still useful) warning fixes

Many of these have been fixed. Some have not.

Patch by Holger Freyther.

Comment 2 Alp Toker 2007-11-20 07:14:51 PST

Created attachment 17417 [details]
Use -Wall, add DirectFB build support

Comment 3 Alp Toker 2007-11-20 07:53:48 PST

Comment on attachment 17417 [details]
Use -Wall, add DirectFB build support

Reviewed by Simon (whose Bugzilla account is broken). Landed in r27926.