Bug 15615 - [GTK] Work towards -Werror, -Wall
Summary: [GTK] Work towards -Werror, -Wall
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 523.x (Safari 3)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords: Cairo, Gtk
Depends on:
Blocks:
 
Reported: 2007-10-22 05:57 PDT by Alp Toker
Modified: 2007-11-20 12:53 PST (History)
0 users

See Also:


Attachments
Holger's (now obsoleted but still useful) warning fixes (12.50 KB, patch)
2007-10-22 05:59 PDT, Alp Toker
no flags Details | Formatted Diff | Diff
Use -Wall, add DirectFB build support (1.82 KB, patch)
2007-11-20 07:14 PST, Alp Toker
alp: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alp Toker 2007-10-22 05:57:58 PDT
Eliminating warnings can help fix real bugs.

Whether we actually want -Werror, -Wall on the default Release build is still up for debate. There are arguments for and against, though I am tending towards the former.
Comment 1 Alp Toker 2007-10-22 05:59:48 PDT
Created attachment 16792 [details]
Holger's (now obsoleted but still useful) warning fixes

Many of these have been fixed. Some have not.

Patch by Holger Freyther.
Comment 2 Alp Toker 2007-11-20 07:14:51 PST
Created attachment 17417 [details]
Use -Wall, add DirectFB build support
Comment 3 Alp Toker 2007-11-20 07:53:48 PST
Comment on attachment 17417 [details]
Use -Wall, add DirectFB build support

Reviewed by Simon (whose Bugzilla account is broken). Landed in r27926.