Bug 156124

Summary: Web Inspector: Remove console.asserts from Worker code in optimized builds
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Description Flags
[PATCH] Proposed Fix
[TEXT] remove-console-asserts.pl none

Description Joseph Pecoraro 2016-04-01 19:08:17 PDT
Remove console.asserts from Worker code in optimized builds.
Comment 1 Radar WebKit Bug Importer 2016-04-01 19:08:42 PDT
Comment 2 Joseph Pecoraro 2016-04-01 19:10:25 PDT
Created attachment 275455 [details]
[PATCH] Proposed Fix
Comment 3 Joseph Pecoraro 2016-04-01 19:15:34 PDT
Created attachment 275456 [details]
[TEXT] remove-console-asserts.pl

Attached the file on its own because the diff looks horrible but the modifications are very small:

  - added a new --input-directory switch
  - moved the existing code into a function
  - use the functions for the different switches
Comment 4 WebKit Commit Bot 2016-04-01 22:23:30 PDT
Comment on attachment 275455 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 275455

Committed r198968: <http://trac.webkit.org/changeset/198968>
Comment 5 WebKit Commit Bot 2016-04-01 22:23:33 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Joseph Pecoraro 2016-04-01 22:41:28 PDT
<http://trac.webkit.org/changeset/198969> Follow up to remove the debug print statement.