Bug 156124

Summary: Web Inspector: Remove console.asserts from Worker code in optimized builds
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix
none
[TEXT] remove-console-asserts.pl none

Joseph Pecoraro
Reported 2016-04-01 19:08:17 PDT
* SUMMARY Remove console.asserts from Worker code in optimized builds.
Attachments
[PATCH] Proposed Fix (6.02 KB, patch)
2016-04-01 19:10 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
[TEXT] remove-console-asserts.pl (2.63 KB, text/x-perl-script)
2016-04-01 19:15 PDT, Joseph Pecoraro 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-04-01 19:08:42 PDT
<rdar://problem/25505031>
Joseph Pecoraro
Comment 2 2016-04-01 19:10:25 PDT
Created attachment 275455 [details] [PATCH] Proposed Fix
Joseph Pecoraro
Comment 3 2016-04-01 19:15:34 PDT
Created attachment 275456 [details] [TEXT] remove-console-asserts.pl Attached the file on its own because the diff looks horrible but the modifications are very small: - added a new --input-directory switch - moved the existing code into a function - use the functions for the different switches
WebKit Commit Bot
Comment 4 2016-04-01 22:23:30 PDT
Comment on attachment 275455 [details] [PATCH] Proposed Fix Clearing flags on attachment: 275455 Committed r198968: <http://trac.webkit.org/changeset/198968>
WebKit Commit Bot
Comment 5 2016-04-01 22:23:33 PDT
All reviewed patches have been landed. Closing bug.
Joseph Pecoraro
Comment 6 2016-04-01 22:41:28 PDT
<http://trac.webkit.org/changeset/198969> Follow up to remove the debug print statement.
Note You need to log in before you can comment on or make changes to this bug.