Bug 156102

Summary: [JSC] Missing PATH_MAX definition
Product: WebKit Reporter: Alberto Garcia <berto>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, cgarcia, commit-queue, keith_miller, mark.lam, mcatanzaro, msaboff, saam, ysuzuki
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ysuzuki: review+

Alberto Garcia
Reported 2016-04-01 02:38:30 PDT
Source/JavaScriptCore/jsc.cpp uses PATH_MAX on non-Windows platforms to get the current working directory, but that macro doesn't need to be defined if the system does not have that limit. This breaks the build in the Hurd, and possibly other systems.
Attachments
Patch (959 bytes, patch)
2016-04-01 02:40 PDT, Alberto Garcia 		ysuzuki: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alberto Garcia
Comment 1 2016-04-01 02:40:38 PDT
Created attachment 275392 [details] Patch
Yusuke Suzuki
Comment 2 2016-04-01 02:59:02 PDT
Comment on attachment 275392 [details] Patch adhoc way, but I think it's ok for jsc.cpp since it's just a harness.
Alberto Garcia
Comment 3 2016-04-01 03:34:25 PDT
(In reply to comment #2) > adhoc way, but I think it's ok for jsc.cpp since it's just a > harness. Right, I chose to do it like this because of that. Thanks!
Alberto Garcia
Comment 4 2016-04-01 03:36:47 PDT
Committed r198945: <http://trac.webkit.org/changeset/198945>
Note You need to log in before you can comment on or make changes to this bug.