Bug 156102

Summary: [JSC] Missing PATH_MAX definition
Product: WebKit Reporter: Alberto Garcia <berto>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, cgarcia, commit-queue, keith_miller, mark.lam, mcatanzaro, msaboff, saam, ysuzuki
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ysuzuki: review+

Description Alberto Garcia 2016-04-01 02:38:30 PDT
Source/JavaScriptCore/jsc.cpp uses PATH_MAX on non-Windows platforms to get the current working directory, but that macro doesn't need to be defined if the system does not have that limit. This breaks the build in the Hurd, and possibly other systems.
Comment 1 Alberto Garcia 2016-04-01 02:40:38 PDT
Created attachment 275392 [details]
Patch
Comment 2 Yusuke Suzuki 2016-04-01 02:59:02 PDT
Comment on attachment 275392 [details]
Patch

adhoc way, but I think it's ok for jsc.cpp since it's just a harness.
Comment 3 Alberto Garcia 2016-04-01 03:34:25 PDT
(In reply to comment #2)
> adhoc way, but I think it's ok for jsc.cpp since it's just a
> harness.

Right, I chose to do it like this because of that.

Thanks!
Comment 4 Alberto Garcia 2016-04-01 03:36:47 PDT
Committed r198945: <http://trac.webkit.org/changeset/198945>