| Summary: | Compile DumpRenderTree with CMake on Mac | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bfulgham, cdumez, commit-queue, gyuyoung.kim, jeremyhu, ossy | ||||
| Priority: | P2 | ||||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Alex Christensen
2016-03-31 16:09:01 PDT
Created attachment 275352 [details]
Patch
Comment on attachment 275352 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=275352&action=review > Source/WebKit2/PlatformMac.cmake:446 > +set(WebKit2_NetworkProcess_OUTPUT_NAME com.apple.WebKit.Networking.Development.xpc) Maybe you can key this off of the "OFFICIAL_BUILD" compile flag we use for, well, "official builds"? > Source/WebKit2/PlatformMac.cmake:714 > +file(WRITE ${DERIVED_SOURCES_DIR}/ForwardingHeaders/WebKit/WebDatabaseManagerPrivate.h "#import <WebKit/mac/Storage/WebDatabaseManagerPrivate.h>") Is this needed because of a bad include path in our sources? Comment on attachment 275352 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=275352&action=review >> Source/WebKit2/PlatformMac.cmake:714 >> +file(WRITE ${DERIVED_SOURCES_DIR}/ForwardingHeaders/WebKit/WebDatabaseManagerPrivate.h "#import <WebKit/mac/Storage/WebDatabaseManagerPrivate.h>") > > Is this needed because of a bad include path in our sources? Maybe Comment on attachment 275352 [details] Patch Clearing flags on attachment: 275352 Committed r198947: <http://trac.webkit.org/changeset/198947> All reviewed patches have been landed. Closing bug. (In reply to comment #4) > Comment on attachment 275352 [details] > Patch > > Clearing flags on attachment: 275352 > > Committed r198947: <http://trac.webkit.org/changeset/198947> It broke the Apple Mac cmake build. :) (In reply to comment #4) > Comment on attachment 275352 [details] > Patch > > Clearing flags on attachment: 275352 > > Committed r198947: <http://trac.webkit.org/changeset/198947> and http://trac.webkit.org/changeset/198948 This caused build failures of webkit-gtk on mac. |