Bug 156080

Summary: Page overlay tests sometimes crash under MockPageOverlayClient::uninstallAllOverlays()
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Tools / TestsAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, lforschler, thorton
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed fix none

Alexey Proskuryakov
Reported 2016-03-31 13:08:27 PDT
rdar://problem/24922183
Attachments
proposed fix (2.87 KB, patch)
2016-03-31 13:11 PDT, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2016-03-31 13:11:46 PDT
Created attachment 275314 [details] proposed fix
Alex Christensen
Comment 2 2016-03-31 19:39:09 PDT
Comment on attachment 275314 [details] proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=275314&action=review r=me I would be ok with removing the dead code in this patch. > Source/WebCore/testing/MockPageOverlayClient.cpp:78 > + // FIXME: This is dead code, nothing ever calls this function. It's not clear to me what the intention was, Let's remove this, then!
Alexey Proskuryakov
Comment 3 2016-03-31 21:02:14 PDT
Comment on attachment 275314 [details] proposed fix There is a lot more code to review, or possibly to fix. Out of scope for this patch.
WebKit Commit Bot
Comment 4 2016-03-31 21:53:59 PDT
Comment on attachment 275314 [details] proposed fix Clearing flags on attachment: 275314 Committed r198940: <http://trac.webkit.org/changeset/198940>
WebKit Commit Bot
Comment 5 2016-03-31 21:54:02 PDT
All reviewed patches have been landed. Closing bug.
Darin Adler
Comment 6 2016-04-01 09:36:06 PDT
To me, removing an unused function seems even better than adding a comment to it.
Alexey Proskuryakov
Comment 7 2016-04-01 09:38:26 PDT
Normally, I would agree, but not in this case, where it's more likely correct to make the function used. rdar://problem/25471523 tracks that.
Note You need to log in before you can comment on or make changes to this bug.