Bug 156071

Summary: run-webkit-tests fails to create user's cache directory when System Integrity Protection is enabled
Product: WebKit Reporter: Daniel Bates <dbates>
Component: Tools / TestsAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, bfulgham, commit-queue, glenn, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Mac   
OS: OS X 10.11   
Bug Depends on:    
Bug Blocks: 155455    
Attachments:
Description Flags
Patch bfulgham: review+

Daniel Bates
Reported 2016-03-31 10:48:14 PDT
On non-Apple Internal machines with System Integrity Protection enabled, run-webkit-tests fails to create the user's cache directory with suffix DIRHELPER_USER_DIR_SUFFIX because the path returned by os.confstr(65538) [1] does not include the suffix as confstr(3) only honors DIRHELPER_USER_DIR_SUFFIX for privileged processes when System Integrity Protection is enabled on non Apple-Internal machines. [1] <http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/port/mac.py?rev=198842#L126>
Attachments
Patch (4.38 KB, patch)
2016-03-31 15:29 PDT, Daniel Bates 		bfulgham: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-03-31 10:48:48 PDT
<rdar://problem/25467827>
Daniel Bates
Comment 2 2016-03-31 15:29:02 PDT
Created attachment 275339 [details] Patch
Brent Fulgham
Comment 3 2016-03-31 16:12:46 PDT
Comment on attachment 275339 [details] Patch r=me
Daniel Bates
Comment 4 2016-03-31 16:45:50 PDT
Committed r198930: <http://trac.webkit.org/changeset/198930>
Note You need to log in before you can comment on or make changes to this bug.