| Summary: | Web Automation: Navigation commands should not return until page loads or fails | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Timothy Hatcher <timothy> | ||||
| Component: | Web Inspector | Assignee: | Timothy Hatcher <timothy> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bburg, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Local Build | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=183007 | ||||||
| Attachments: |
|
||||||
|
Description
Timothy Hatcher
2016-03-31 08:07:37 PDT
Created attachment 275282 [details]
Patch
Comment on attachment 275282 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=275282&action=review > Source/WebKit2/UIProcess/Automation/WebAutomationSession.cpp:418 > +} I believe that this should cancel any pending async script evaluations first so that they error out. We can add this later. > Source/WebKit2/UIProcess/Automation/WebAutomationSession.h:85 > + void navigationOccuredForPage(const WebPageProxy&); Please fix spelling: navigationOccurredForPage > Source/WebKit2/UIProcess/WebPageProxy.cpp:3126 > + if (auto automationSession = process().processPool().automationSession()) Nit: auto should be auto& or auto* so the type is less mysterious (and so we don't accidentally make a copy in some cases). Comment on attachment 275282 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=275282&action=review >> Source/WebKit2/UIProcess/Automation/WebAutomationSession.cpp:418 >> +} > > I believe that this should cancel any pending async script evaluations first so that they error out. We can add this later. That is already done on the WebProcess side. |