Bug 156050 – [iOS WK2] Avoid creating tiles that are too large for rendering

• Component: New Bugs
• Status: RESOLVED FIXED

[Simon Fraser (smfr)]

[iOS WK2] Avoid creating tiles that are too large for rendering

[Simon Fraser (smfr)]

Created attachment 275247 [details]
Patch

[Simon Fraser (smfr)]

Created attachment 275253 [details]
Patch

[Darin Adler]

Comment on attachment 275253 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=275253&action=review

> Source/WebCore/platform/graphics/ca/TileController.cpp:499
> +    surfaceSizeLimit.scale(1 / m_deviceScaleFactor);

Is this always going to be correct when devices have more than a single display with different device scale factors?

> Source/WebCore/platform/graphics/ca/TileController.cpp:512
> +        tileSize.setWidth(std::min(std::max<int>(ceilf(boundsWithoutMargin().width() * tileGrid().scale()), kDefaultTileSize), maxTileSize.height()));

Surprised to see maxTileSize.height() here in a line that’s about width. Wouldn’t width() be right?

[Simon Fraser (smfr)]

(In reply to comment #3)
> Comment on attachment 275253 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=275253&action=review
> 
> > Source/WebCore/platform/graphics/ca/TileController.cpp:499
> > +    surfaceSizeLimit.scale(1 / m_deviceScaleFactor);
> 
> Is this always going to be correct when devices have more than a single
> display with different device scale factors?

Yes, this is the m_deviceScaleFactor for the window that this TileController's view is (primarily) on.

> > Source/WebCore/platform/graphics/ca/TileController.cpp:512
> > +        tileSize.setWidth(std::min(std::max<int>(ceilf(boundsWithoutMargin().width() * tileGrid().scale()), kDefaultTileSize), maxTileSize.height()));
> 
> Surprised to see maxTileSize.height() here in a line that’s about width.
> Wouldn’t width() be right?

Yes, thanks.

[Simon Fraser (smfr)]

https://trac.webkit.org/r198875