Bug 156046

Summary: Need to expose makeAllShadowRootsOpen in WKWebProcessPlugInScriptWorld.
Product: WebKit Reporter: Yongjun Zhang <yongjun_zhang>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, commit-queue, mitz, rniwa, sam
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch.
mitz: review+
Address review comment before landing. none

Yongjun Zhang
Reported 2016-03-30 16:27:52 PDT
http://trac.webkit.org/changeset/195686 added C SPI WKBundleScriptWorldMakeAllShadowRootsOpen, we should also expose makeAllShadowRootsOpen in WebKit ObjC SPI.
Attachments
Patch. (2.22 KB, patch)
2016-03-30 16:32 PDT, Yongjun Zhang 		mitz: review+
DetailsFormatted DiffDiff
Address review comment before landing. (2.26 KB, patch)
2016-03-30 19:57 PDT, Yongjun Zhang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yongjun Zhang
Comment 1 2016-03-30 16:32:33 PDT
Created attachment 275235 [details] Patch.
Yongjun Zhang
Comment 2 2016-03-30 16:33:37 PDT
<rdar://problem/23183183>
mitz
Comment 3 2016-03-30 18:30:02 PDT
Comment on attachment 275235 [details] Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=275235&action=review > Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInScriptWorld.h:41 > +- (void)makeAllShadowRootsOpen; WK_AVAILABLE(WK_MAC_TBA, WK_IOS_TBA)
Yongjun Zhang
Comment 4 2016-03-30 19:57:49 PDT
Created attachment 275258 [details] Address review comment before landing.
WebKit Commit Bot
Comment 5 2016-03-30 20:56:24 PDT
Comment on attachment 275258 [details] Address review comment before landing. Clearing flags on attachment: 275258 Committed r198881: <http://trac.webkit.org/changeset/198881>
WebKit Commit Bot
Comment 6 2016-03-30 20:56:28 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.