| Summary: | Fix Content-Range requests when not using the NetworkCache with NetworkSession | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, jer.noble | ||||||
| Priority: | P2 | ||||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Alex Christensen
2016-03-30 13:01:13 PDT
Created attachment 275215 [details]
Patch
Comment on attachment 275215 [details]
Patch
Test case?
I looked into writing an automated test case, but this is only needed when the NetworkCache is disabled, which is not true for WebKitTestRunner, and when loading from the network, which is not true for TestWebKitAPI. Doing the manual test in the radar certainly shows that this fixes a problem with videos on WK2 apps with the NetworkCache disabled. Comment on attachment 275215 [details]
Patch
Could you please add a regression test?
Created attachment 275562 [details]
Patch
(In reply to comment #4) > Comment on attachment 275215 [details] > Patch > > Could you please add a regression test? I don't think it is reasonable to do this because this is to fix a compatibility bug with a program that does not use the NetworkCache, which is not possible with a program that is linked with a recent version of WebKit. Comment on attachment 275562 [details] Patch Clearing flags on attachment: 275562 Committed r199090: <http://trac.webkit.org/changeset/199090> All reviewed patches have been landed. Closing bug. |