Bug 156027

Summary: Avoid WebCore-prefixed paths when building WebCore
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebCore Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, ap, bfulgham, commit-queue, darin
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Brent Fulgham 2016-03-30 10:23:33 PDT 
A few files (e.g., “Font.h”, "ColorCG.h", some Video files) refer to “<WebCore/CoreGraphicsSPI.h>”, which doesn’t always exist on Windows at the time the file is compiled. The CoreGraphicsSPI.h file lives in “WebCore/platform/spi/cg/CoreGraphicsSPI.h”, and can be found with a normal ‘#include “CoreGraphicsSPI.h”. It’s only after a post-build step copies the file to “DerivedSources/ForwardingHeaders/WebCore/CoreGraphicsSPI.h” that the ‘#include <WebCore/CoreGraphicsSPI.h>” form works.

When a non-clean build is performed, this is fine, so EWS probably works properly most of the time. But if something prompts it to clean the build output, the file doesn’t exist and the build fails, improperly blaming the current patch.

We should be consistent about file access in WebCore so that we avoid these problems.
Comment 1 Brent Fulgham 2016-03-30 10:27:19 PDT 
Created attachment 275197 [details]
Patch
Comment 2 David Kilzer (:ddkilzer) 2016-03-30 11:44:13 PDT 
Comment on attachment 275197 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2016-03-30 12:36:10 PDT 
Comment on attachment 275197 [details]
Patch

Clearing flags on attachment: 275197

Committed r198850: <http://trac.webkit.org/changeset/198850>
Comment 4 WebKit Commit Bot 2016-03-30 12:36:14 PDT 
All reviewed patches have been landed.  Closing bug.