Bug 156006

Summary: Make dependency injection in unit tests more explicit
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Perf DashboardAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, dewei_zhu, joepeck, kling, koivisto, rniwa, slewis
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Cleanup joepeck: review+

Ryosuke Niwa
Reported 2016-03-29 20:30:59 PDT
In order to run server tests and unit tests, we need to make the dependency injection of mock models via before/beforeEach explicit so that they won't collide with real model objects created in server tests.
Attachments
Cleanup (20.90 KB, patch)
2016-03-29 20:38 PDT, Ryosuke Niwa 		joepeck: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2016-03-29 20:38:49 PDT
Created attachment 275171 [details] Cleanup
Joseph Pecoraro
Comment 2 2016-03-29 21:13:57 PDT
Comment on attachment 275171 [details] Cleanup r=me
Ryosuke Niwa
Comment 3 2016-03-29 21:16:44 PDT
Committed r198826: <http://trac.webkit.org/changeset/198826>
Note You need to log in before you can comment on or make changes to this bug.