Bug 155996 – Add a style for Data Detectors links

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Enrica Casucci]

Based on indication from the data detection engine, we should style some of the links differently.

rdar://problem/25343514

[Enrica Casucci]

Created attachment 275226 [details]
Patch

[Sam Weinig]

Comment on attachment 275226 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=275226&action=review

> Source/WebCore/editing/cocoa/DataDetection.mm:55
> +const char *dataDetectorsLinkStyle = "-webkit-text-decoration-color:rgb(199, 199, 204); color:initial;";

* on the wrong side.

> Source/WebCore/editing/cocoa/DataDetection.mm:332
> +    isSubResult = length > 1;

Is it really necessary for this calculation to happen in this function? Seems like it would be cleaner to do it at the call site.

[Enrica Casucci]

> > Source/WebCore/editing/cocoa/DataDetection.mm:332
> > +    isSubResult = length > 1;
> 
> Is it really necessary for this calculation to happen in this function?
> Seems like it would be cleaner to do it at the call site.
I believe it makes more sense to do it inside the function where we decide what is a sub result.

[Enrica Casucci]

(In reply to comment #3)
> > > Source/WebCore/editing/cocoa/DataDetection.mm:332
> > > +    isSubResult = length > 1;
> > 
> > Is it really necessary for this calculation to happen in this function?
> > Seems like it would be cleaner to do it at the call site.
> I believe it makes more sense to do it inside the function where we decide
> what is a sub result.

Actually, I think you're correct. I'll change it.

[Enrica Casucci]

Committed revision 198864.