Bug 155982

Summary: JSC::Debugger cleanup after recent changes
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: JavaScriptCoreAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2016-03-29 12:43:55 PDT
* SUMMARY JSC::Debugger cleanup after recent changes. 1. Debugger should not start out assuming breakpoints are active. 2. Debugger does not need to recompile JS when enabling the Sampling Profiler! And I believe all ports are using the new sampling profiler!
Attachments
[PATCH] Proposed Fix (1.77 KB, patch)
2016-03-29 12:45 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2016-03-29 12:45:52 PDT
Created attachment 275120 [details] [PATCH] Proposed Fix
Mark Lam
Comment 2 2016-03-29 12:50:56 PDT
Comment on attachment 275120 [details] [PATCH] Proposed Fix r=me
Saam Barati
Comment 3 2016-03-29 12:51:33 PDT
Comment on attachment 275120 [details] [PATCH] Proposed Fix LGTM too. Nice catch
WebKit Commit Bot
Comment 4 2016-03-29 13:12:17 PDT
Comment on attachment 275120 [details] [PATCH] Proposed Fix Clearing flags on attachment: 275120 Committed r198791: <http://trac.webkit.org/changeset/198791>
WebKit Commit Bot
Comment 5 2016-03-29 13:12:20 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.