Summary: | Web Inspector: REGRESSION: ⌘E and ⌘G text searching does not work | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||
Component: | Web Inspector | Assignee: | Joseph Pecoraro <joepeck> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Joseph Pecoraro
2016-03-29 11:38:08 PDT
This was partially caused by: http://trac.webkit.org/changeset/198603 But mainly the problem is that the RecordingContentView in the background TimelineTab thinks it is visible and has activated its own keyboard shortcut handling: [Log] Trace: enableKeyboardShortcuts enableKeyboardShortcuts (FindBanner.js:253) shown (ContentBrowser.js:262) shown (TimelineRecordingContentView.js:168) prepareToShow (BackForwardEntry.js:78) _showEntry (ContentViewContainer.js:485) showBackForwardEntryForIndex (ContentViewContainer.js:150) showContentView (ContentViewContainer.js:126) _showTimelineViewForType (TimelineTabContentView.js:529) restoreFromCookie (TimelineTabContentView.js:313) _recordingSelected (TimelineTabContentView.js:478) _recordingLoaded (TimelineTabContentView.js:483) TimelineTabContentView (TimelineTabContentView.js:87) _createTabContentViewForType (Main.js:490) contentLoaded (Main.js:416) (anonymous function) Which gets first stab at the keyboard shortcut instead of the actually active tab's keyboard shortcut handling: [Log] Trace: enableKeyboardShortcuts enableKeyboardShortcuts (FindBanner.js:253) shown (ContentBrowser.js:262) shown (ContentBrowserTabContentView.js:98) prepareToShow (BackForwardEntry.js:78) _showEntry (ContentViewContainer.js:485) showBackForwardEntryForIndex (ContentViewContainer.js:150) showContentView (ContentViewContainer.js:126) _tabBarItemSelected (TabBrowser.js:204) dispatch (Object.js:161) dispatchEventToListeners (Object.js:168) selectedTabBarItem (TabBar.js:374) contentLoaded (Main.js:424) (anonymous function) Created attachment 275119 [details]
[PATCH] Proposed Fix
Comment on attachment 275119 [details] [PATCH] Proposed Fix Clearing flags on attachment: 275119 Committed r198794: <http://trac.webkit.org/changeset/198794> All reviewed patches have been landed. Closing bug. |