Bug 155964

Summary: Shield WebRTC JS built-ins from user scripts
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebCore Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: adam.bergkvist, commit-queue, eric.carlson
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Improving test none

Description youenn fablet 2016-03-29 00:36:30 PDT 
We should shield WebRTC JS built-ins from user scripts, for instance in RTCPeerConnection.js or RTCPeerConnectionInternals.
Comment 1 youenn fablet 2016-06-29 06:08:49 PDT 
Created attachment 282342 [details]
Patch
Comment 2 youenn fablet 2016-07-04 06:55:22 PDT 
Created attachment 282715 [details]
Improving test
Comment 3 youenn fablet 2016-07-04 06:59:10 PDT 
(In reply to comment #2)
> Created attachment 282715 [details]
> Improving test

I run the tests and the patch worked as expected on the modified tests (removing console.log lines).

To be noted though that the two modified tests need rebasing (before and after this patch) and are skipped by default.
Is there a reason to skip them?
Should they be activated for GTK?
It seems that they are useful even if not fully passing yet.
Comment 4 WebKit Commit Bot 2016-07-04 11:32:09 PDT 
Comment on attachment 282715 [details]
Improving test

Clearing flags on attachment: 282715

Committed r202810: <http://trac.webkit.org/changeset/202810>
Comment 5 WebKit Commit Bot 2016-07-04 11:32:13 PDT 
All reviewed patches have been landed.  Closing bug.