Bug 155951

Summary:

Modern IDB: Remove abstract base classes for all IDB DOM classes

Product:

WebKit

Reporter:

Brady Eidson <beidson>

Component:

WebCore Misc.

Assignee:

Brady Eidson <beidson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, alecflett, commit-queue, jsbell

Priority:

Version:

Safari 9

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

149117

Attachments:

Description	Flags
Patch v1	achristensen: review+
Patch for landing v1	none
Patch for landing v2	none

Brady Eidson

Reported 2016-03-28 12:46:50 PDT

Modern IDB: Remove abstract base classes for all IDB DOM classes Not needed anymore since we've removed Legacy IDB.

Attachments
Patch v1 (437.83 KB, patch) 2016-03-28 13:01 PDT, Brady Eidson	achristensen: review+	Details Formatted Diff Diff
Patch for landing v1 (437.80 KB, patch) 2016-03-28 14:21 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Patch for landing v2 (438.84 KB, patch) 2016-03-28 14:23 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Brady Eidson

Comment 1 2016-03-28 13:01:39 PDT

Created attachment 275039 [details] Patch v1

WebKit Commit Bot

Comment 2 2016-03-28 13:03:20 PDT

Attachment 275039 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/indexeddb/IDBTransaction.cpp:35: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/Modules/indexeddb/IDBCursor.cpp:36: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/Modules/indexeddb/IDBRequest.cpp:288: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Total errors found: 3 in 46 files If any of these errors are false positives, please file a bug against check-webkit-style.

Alex Christensen

Comment 3 2016-03-28 13:15:23 PDT

Comment on attachment 275039 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=275039&action=review > Source/WebCore/Modules/indexeddb/IDBAny.cpp:48 > + , m_database(adoptRef(&database.leakRef())) WTFMove > Source/WebCore/Modules/indexeddb/IDBFactory.h:-53 > - // FIXME: getDatabaseNames is no longer a web-facing API, and should be removed from IDBFactory. > - // The Web Inspector currently uses this to enumerate the list of databases, but is more complicated as a result. > - // We should provide a simpler API to the Web Inspector then remove getDatabaseNames. Is this still true?

Brady Eidson

Comment 4 2016-03-28 13:25:09 PDT

(In reply to comment #3) > Comment on attachment 275039 [details] > > Source/WebCore/Modules/indexeddb/IDBFactory.h:-53 > > - // FIXME: getDatabaseNames is no longer a web-facing API, and should be removed from IDBFactory. > > - // The Web Inspector currently uses this to enumerate the list of databases, but is more complicated as a result. > > - // We should provide a simpler API to the Web Inspector then remove getDatabaseNames. > > Is this still true? Yes.

Alex Christensen

Comment 5 2016-03-28 13:56:55 PDT

Comment on attachment 275039 [details] Patch v1 Then we should keep the comment.

Brady Eidson

Comment 6 2016-03-28 14:21:11 PDT

Created attachment 275051 [details] Patch for landing v1

Brady Eidson

Comment 7 2016-03-28 14:23:20 PDT

Created attachment 275052 [details] Patch for landing v2

WebKit Commit Bot

Comment 8 2016-03-28 15:49:05 PDT

Comment on attachment 275052 [details] Patch for landing v2 Clearing flags on attachment: 275052 Committed r198762: <http://trac.webkit.org/changeset/198762>

WebKit Commit Bot

Comment 9 2016-03-28 15:49:10 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.