Bug 155949

Summary: [RTL Scrollbars] Position:sticky can be positioned inside vertical RTL scrollbar
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, commit-queue, dino, esprehn+autocc, glenn, jonlee, kondapallykalyan, simon.fraser, thorton
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews123 for ios-simulator-wk2
none
Patch simon.fraser: review+

Myles C. Maxfield
Reported 2016-03-28 11:52:07 PDT
[RTL Scrollbars] Position:sticky can be positioned inside vertical RTL scrollbar
Attachments
Patch (17.96 KB, patch)
2016-03-28 11:54 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews123 for ios-simulator-wk2 (834.29 KB, application/zip)
2016-03-28 12:46 PDT, Build Bot 		no flags
Details
Patch (18.95 KB, patch)
2016-03-28 13:04 PDT, Myles C. Maxfield 		simon.fraser: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2016-03-28 11:54:32 PDT
Created attachment 275034 [details] Patch
Build Bot
Comment 2 2016-03-28 12:46:29 PDT
Comment on attachment 275034 [details] Patch Attachment 275034 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/1056640 New failing tests: fast/scrolling/rtl-scrollbars-sticky-document.html fast/scrolling/rtl-scrollbars-sticky-iframe.html fast/scrolling/rtl-scrollbars-sticky-document-2.html fast/scrolling/rtl-scrollbars-sticky-iframe-2.html
Build Bot
Comment 3 2016-03-28 12:46:31 PDT
Created attachment 275037 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.10.5
Myles C. Maxfield
Comment 4 2016-03-28 13:04:12 PDT
Created attachment 275040 [details] Patch
Simon Fraser (smfr)
Comment 5 2016-03-28 13:18:59 PDT
Comment on attachment 275040 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=275040&action=review > Source/WebCore/ChangeLog:3 > + [RTL Scrollbars] Position:sticky can be positioned inside vertical RTL scrollbar inside -> under? > Source/WebCore/rendering/RenderBoxModelObject.cpp:455 > + if (enclosingClippingBox.layer() && enclosingClippingBox.style().shouldPlaceBlockDirectionScrollbarOnLeft()) hasLayer() is slightly more efficient than testing layer().
Myles C. Maxfield
Comment 6 2016-03-28 14:37:40 PDT
Committed r198758: <http://trac.webkit.org/changeset/198758>
Note You need to log in before you can comment on or make changes to this bug.