Bug 155949 - [RTL Scrollbars] Position:sticky can be positioned inside vertical RTL scrollbar
Summary: [RTL Scrollbars] Position:sticky can be positioned inside vertical RTL scrollbar
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-28 11:52 PDT by Myles C. Maxfield
Modified: 2016-03-28 14:37 PDT (History)
9 users (show)

See Also:

Attachments
Patch (17.96 KB, patch)
2016-03-28 11:54 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews123 for ios-simulator-wk2 (834.29 KB, application/zip)
2016-03-28 12:46 PDT, Build Bot 		no flags Details
Patch (18.95 KB, patch)
2016-03-28 13:04 PDT, Myles C. Maxfield 		simon.fraser: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2016-03-28 11:52:07 PDT 
[RTL Scrollbars] Position:sticky can be positioned inside vertical RTL scrollbar
Comment 1 Myles C. Maxfield 2016-03-28 11:54:32 PDT 
Created attachment 275034 [details]
Patch
Comment 2 Build Bot 2016-03-28 12:46:29 PDT 
Comment on attachment 275034 [details]
Patch

Attachment 275034 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1056640

New failing tests:
fast/scrolling/rtl-scrollbars-sticky-document.html
fast/scrolling/rtl-scrollbars-sticky-iframe.html
fast/scrolling/rtl-scrollbars-sticky-document-2.html
fast/scrolling/rtl-scrollbars-sticky-iframe-2.html
Comment 3 Build Bot 2016-03-28 12:46:31 PDT 
Created attachment 275037 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.10.5
Comment 4 Myles C. Maxfield 2016-03-28 13:04:12 PDT 
Created attachment 275040 [details]
Patch
Comment 5 Simon Fraser (smfr) 2016-03-28 13:18:59 PDT 
Comment on attachment 275040 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=275040&action=review

> Source/WebCore/ChangeLog:3
> +        [RTL Scrollbars] Position:sticky can be positioned inside vertical RTL scrollbar

inside -> under?

> Source/WebCore/rendering/RenderBoxModelObject.cpp:455
> +        if (enclosingClippingBox.layer() && enclosingClippingBox.style().shouldPlaceBlockDirectionScrollbarOnLeft())

hasLayer() is slightly more efficient than testing layer().
Comment 6 Myles C. Maxfield 2016-03-28 14:37:40 PDT 
Committed r198758: <http://trac.webkit.org/changeset/198758>