| Summary: | Rely on PlatformLayer to choose the TextureMapperPlatformLayer impl | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Emanuele Aina <emanuele.aina> | ||||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, darin, ggaren, mcatanzaro, pnormand, zan | ||||||
| Priority: | P2 | ||||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Emanuele Aina
2016-03-26 18:12:22 PDT
Created attachment 274991 [details]
Patch
Attachment 274991 [details] did not pass style-queue:
ERROR: Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5]
Total errors found: 1 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 274991 [details]
Patch
Clever, I like it.
You need to not break EFL, though. Seems it's not getting any typedef for PlatformLayer?
Comment on attachment 274991 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=274991&action=review > Source/WebCore/ChangeLog:4 > + Need the bug URL (OOPS!). And the bugzilla URL should be mentioned here. Created attachment 275187 [details]
Patch
Comment on attachment 275187 [details]
Patch
LGTM. The Windows EWS error looks unrelated.
Emanuele, if you want the commit-queue bot to land this, please let us know :) Yes please! Should I request it in some particular way? Comment on attachment 275187 [details]
Patch
Next time you can set cq? so we know you want the commit-queue to land this.
Comment on attachment 275187 [details] Patch Clearing flags on attachment: 275187 Committed r199000: <http://trac.webkit.org/changeset/199000> All reviewed patches have been landed. Closing bug. |