Bug 155926 - Rely on PlatformLayer to choose the TextureMapperPlatformLayer impl
Summary: Rely on PlatformLayer to choose the TextureMapperPlatformLayer impl
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-26 18:12 PDT by Emanuele Aina
Modified: 2016-04-04 03:21 PDT (History)
6 users (show)

See Also:

Attachments
Patch (5.49 KB, patch)
2016-03-26 18:13 PDT, Emanuele Aina 		no flags Details | Formatted Diff | Diff
Patch (6.50 KB, patch)
2016-03-30 01:53 PDT, Emanuele Aina 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Emanuele Aina 2016-03-26 18:12:22 PDT 
Rely on PlatformLayer to choose the TextureMapperPlatformLayer impl
Comment 1 Emanuele Aina 2016-03-26 18:13:38 PDT 
Created attachment 274991 [details]
Patch
Comment 2 WebKit Commit Bot 2016-03-26 18:15:56 PDT 
Attachment 274991 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Michael Catanzaro 2016-03-28 07:40:40 PDT 
Comment on attachment 274991 [details]
Patch

Clever, I like it.

You need to not break EFL, though. Seems it's not getting any typedef for PlatformLayer?
Comment 4 Philippe Normand 2016-03-29 00:13:11 PDT 
Comment on attachment 274991 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274991&action=review

> Source/WebCore/ChangeLog:4
> +        Need the bug URL (OOPS!).

And the bugzilla URL should be mentioned here.
Comment 5 Emanuele Aina 2016-03-30 01:53:21 PDT 
Created attachment 275187 [details]
Patch
Comment 6 Zan Dobersek 2016-03-30 04:06:46 PDT 
Comment on attachment 275187 [details]
Patch

LGTM. The Windows EWS error looks unrelated.
Comment 7 Philippe Normand 2016-04-04 02:01:27 PDT 
Emanuele, if you want the commit-queue bot to land this, please let us know :)
Comment 8 Emanuele Aina 2016-04-04 02:19:27 PDT 
Yes please! Should I request it in some particular way?
Comment 9 Philippe Normand 2016-04-04 02:30:34 PDT 
Comment on attachment 275187 [details]
Patch

Next time you can set cq? so we know you want the commit-queue to land this.
Comment 10 WebKit Commit Bot 2016-04-04 03:21:31 PDT 
Comment on attachment 275187 [details]
Patch

Clearing flags on attachment: 275187

Committed r199000: <http://trac.webkit.org/changeset/199000>
Comment 11 WebKit Commit Bot 2016-04-04 03:21:36 PDT 
All reviewed patches have been landed.  Closing bug.