Bug 155890

Summary: Disk cache speculative validation requests do not have the 'Referer' HTTP header set
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, barraclough, beidson, cgarcia, commit-queue, koivisto, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Chris Dumez 2016-03-25 10:23:25 PDT 
Disk cache speculative validation requests do not have the 'Referer' HTTP header set. This is breaking some streaming sites (such as twitch.tv).
Comment 1 Chris Dumez 2016-03-25 10:23:46 PDT 
rdar://problem/25279962
Comment 2 Chris Dumez 2016-03-27 15:39:32 PDT 
Created attachment 274999 [details]
Patch
Comment 3 Antti Koivisto 2016-03-28 05:34:50 PDT 
Comment on attachment 274999 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274999&action=review

r=me

> LayoutTests/http/tests/cache/disk-cache/speculative-validation/validation-request-expected.txt:8
> +PASS validationRequestHeader('Referer') is initialReferer

The test seems rather barebones considering this affects all headers, not just "Referer'
Comment 4 Chris Dumez 2016-03-28 09:03:47 PDT 
Created attachment 275022 [details]
Patch
Comment 5 Chris Dumez 2016-03-28 09:04:31 PDT 
Comment on attachment 275022 [details]
Patch

Clearing flags on attachment: 275022

Committed r198741: <http://trac.webkit.org/changeset/198741>
Comment 6 Chris Dumez 2016-03-28 09:04:36 PDT 
All reviewed patches have been landed.  Closing bug.