Bug 155889

Summary:

WebKit.xcworkspace "All Source" scheme always copies OS X WebKitSystemInterface libraries

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

Tools / Tests

Assignee:

Daniel Bates <dbates>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, ddkilzer, hofione, lforschler

Priority:

Version:

WebKit Local Build

Hardware:

iPhone / iPad

OS:

iOS 9.3

Attachments:

Description	Flags
Patch	ap: review+

Daniel Bates

Reported 2016-03-25 10:19:04 PDT

The WebKit.xcworkspace "All Source" scheme always copies the OS X WebKitSystemInterface libraries regardless of the selected base SDK. We should copy the SDK-specific WebKitSystemInterface libraries.

Attachments
Patch (2.04 KB, patch) 2016-03-25 10:21 PDT, Daniel Bates	ap: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Daniel Bates

Comment 1 2016-03-25 10:21:25 PDT

Created attachment 274915 [details] Patch

Alexey Proskuryakov

Comment 2 2016-03-25 10:56:05 PDT

Comment on attachment 274915 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=274915&action=review > WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme:12 > + scriptText = ""$SRCROOT/../../Tools/Scripts/copy-webkitlibraries-to-product-directory" --wksi --sdk $SDKROOT"> How does this work? I thought that --sdk took names like "iphonesimulator", not paths.

Daniel Bates

Comment 3 2016-03-25 11:40:06 PDT

(In reply to comment #2) > > WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme:12 > > + scriptText = ""$SRCROOT/../../Tools/Scripts/copy-webkitlibraries-to-product-directory" --wksi --sdk $SDKROOT"> > > How does this work? I thought that --sdk took names like "iphonesimulator", > not paths. --sdk can take a path, just like the command line option of the same name for xcrun. The code in webkitdirs.pm knows how to reason about an SDK given as a path.

Daniel Bates

Comment 4 2016-03-25 11:48:14 PDT

> > WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme:12 > > + scriptText = ""$SRCROOT/../../Tools/Scripts/copy-webkitlibraries-to-product-directory" --wksi --sdk $SDKROOT"> > Will add "s around $SDKROOT before landing as it may contain space characters.

Daniel Bates

Comment 5 2016-03-27 22:07:08 PDT

Committed r198727: <http://trac.webkit.org/changeset/198727>

Note You need to log in before you can comment on or make changes to this bug.