Bug 155888

Summary:

Web Automation: Add Automation protocol commands to handle JavaScript dialogs

Product:

WebKit

Reporter:

Timothy Hatcher <timothy>

Component:

Web Inspector

Assignee:

Timothy Hatcher <timothy>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	bburg: review+, timothy: commit-queue-

Description Timothy Hatcher 2016-03-25 09:58:02 PDT

We need to accept, dismiss and get the message. Prompts need support for setting the user input.

Comment 1 Radar WebKit Bug Importer 2016-03-25 09:58:31 PDT

<rdar://problem/25360218>

Comment 2 Timothy Hatcher 2016-03-25 10:00:22 PDT

Created attachment 274912 [details]
Patch

Comment 3 BJ Burg 2016-03-25 17:20:06 PDT

Comment on attachment 274912 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274912&action=review

r=me

> Source/WebKit2/UIProcess/Automation/Automation.json:299
> +            "name": "setUserInputForCurrentJavaScriptPrompt",

Can this be renamed to 'insertTextForCurrentJavaScriptPrompt' ? The setXXX prefix doesn't translate well to ObjC.

Comment 4 Timothy Hatcher 2016-03-28 09:41:48 PDT

https://trac.webkit.org/r198740