Bug 155882

Summary:

Turned on ENABLE_REQUEST_ANIMATION_FRAME by default for any port.

Product:

WebKit

Reporter:

Konstantin Tokarev <annulen>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, commit-queue, gyuyoung.kim, joepeck, lforschler, mcatanzaro, ossy

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Konstantin Tokarev

Reported 2016-03-25 05:26:09 PDT

It was already enabled in all trunk ports, and is required for WebInspectorUI to work.

Attachments
Patch (5.14 KB, patch) 2016-03-25 05:30 PDT, Konstantin Tokarev	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Konstantin Tokarev

Comment 1 2016-03-25 05:30:18 PDT

Created attachment 274901 [details] Patch

Csaba Osztrogonác

Comment 2 2016-03-25 06:30:54 PDT

You could remove it from OptionsWin.cmake too.

Konstantin Tokarev

Comment 3 2016-03-25 06:32:31 PDT

(In reply to comment #2) > You could remove it from OptionsWin.cmake too. And from OptionsEfl, as well. I haven't done that because Win and Efl declare this option as PUBLIC, so it would change behavior, but if everyone agrees I'll remove these too.

Csaba Osztrogonác

Comment 4 2016-03-25 06:35:59 PDT

After a little digging, I found a 2 years old webkit-dev discussion: https://lists.webkit.org/pipermail/webkit-dev/2014-March/026366.html In this case it would be better to completely remove ENABLE(REQUEST_ANIMATION_FRAME) guards from the trunk.

Konstantin Tokarev

Comment 5 2016-03-25 06:41:09 PDT

Note that WebKit currently builds fine for me with !ENABLE(REQUEST_ANIMATION_FRAME), so apparently it requires almost no effort to maintain.

Michael Catanzaro

Comment 6 2016-03-25 06:58:15 PDT

(In reply to comment #4) > In this case it would be better to completely remove > ENABLE(REQUEST_ANIMATION_FRAME) guards from the trunk. I agree, we want to remove build options whenever they're not needed anymore, and this seems like a clear candidate.

WebKit Commit Bot

Comment 7 2016-03-25 07:47:49 PDT

Comment on attachment 274901 [details] Patch Clearing flags on attachment: 274901 Committed r198666: <http://trac.webkit.org/changeset/198666>

WebKit Commit Bot

Comment 8 2016-03-25 07:47:55 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.