Bug 155869

Summary: Use webkitdirs::determineXcodeSDK() instead of webkitdirs::willUseIOSDeviceSDK() in copy-webkitlibraries-to-product-directory
Product: WebKit Reporter: Daniel Bates <dbates>
Component: Tools / TestsAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, ap, ddkilzer, dean_johnson, lforschler
Priority: P2    
Version: WebKit Local Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch ap: review+

Daniel Bates
Reported 2016-03-24 21:18:43 PDT
It is sufficient to call webkitdirs::determineXcodeSDK() at the top of script copy-webkitlibraries-to-product-directory to process the --sdk/--device/--ios-simulator command line arguments instead of calling webkitdirs::willUseIOSDeviceSDK() as the latter ultimately calls the former. The purpose of the function webkitdirs::willUseIOSDeviceSDK() is to determine if we will use the iOS device SDK (from parsing the --sdk option or from the presence of the --device option) and as its name implies it returns a boolean value. In contrast, webkitdirs::determineXcodeSDK() does not have a return value and it simply computes and caches the Xcode SDK we will use so that webkitdirs::willUseIOSDeviceSDK() can use this cache.
Attachments
Patch (1.82 KB, patch)
2016-03-24 21:19 PDT, Daniel Bates 		ap: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2016-03-24 21:19:34 PDT
Created attachment 274882 [details] Patch
Daniel Bates
Comment 2 2016-03-25 09:05:25 PDT
Committed r198668: <http://trac.webkit.org/changeset/198668>
Note You need to log in before you can comment on or make changes to this bug.