Bug 155868

Summary: Add a compile time flag for using QTKit
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, jeremyj-wk, jer.noble
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Alex Christensen
Reported 2016-03-24 21:02:58 PDT
Add a compile time flag for using QTKit
Attachments
Patch (4.19 KB, patch)
2016-03-24 21:04 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (5.54 KB, patch)
2016-03-25 13:37 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2016-03-24 21:04:00 PDT
Created attachment 274879 [details] Patch
Daniel Bates
Comment 2 2016-03-24 22:44:13 PDT
Comment on attachment 274879 [details] Patch OK.
Alex Christensen
Comment 3 2016-03-25 10:25:31 PDT
http://trac.webkit.org/changeset/198673
Alex Christensen
Comment 4 2016-03-25 13:37:13 PDT
Reopening to attach new patch.
Alex Christensen
Comment 5 2016-03-25 13:37:14 PDT
Created attachment 274934 [details] Patch
Alex Christensen
Comment 6 2016-03-25 13:39:10 PDT
Instead of completely getting rid of Mac's WebVideoFullscreenController implementation, I get rid of just the QTKit parts of it. This way it compiles all the way.
WebKit Commit Bot
Comment 7 2016-03-25 16:06:08 PDT
Comment on attachment 274934 [details] Patch Clearing flags on attachment: 274934 Committed r198696: <http://trac.webkit.org/changeset/198696>
WebKit Commit Bot
Comment 8 2016-03-25 16:06:11 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.