Bug 155859

Summary:

Web Inspector: protocol generator should prefix C++ filenames with the protocol group

Product:

WebKit

Reporter:

Blaze Burg <bburg>

Component:

Web Inspector

Assignee:

Blaze Burg <bburg>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
WIP - needs build system work	none
Proposed Fix	achristensen: review+

Blaze Burg

Reported 2016-03-24 16:40:21 PDT

Don't hardcode 'Inspector'.

Attachments
WIP - needs build system work (19.49 KB, patch) 2016-03-24 17:51 PDT, Blaze Burg	no flags	Details Formatted Diff Diff
Proposed Fix (123.54 KB, patch) 2016-03-25 10:26 PDT, Blaze Burg	achristensen: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2016-03-24 16:41:01 PDT

<rdar://problem/25349859>

Blaze Burg

Comment 2 2016-03-24 17:51:19 PDT

Created attachment 274868 [details] WIP - needs build system work

Blaze Burg

Comment 3 2016-03-25 10:26:35 PDT

Created attachment 274916 [details] Proposed Fix

WebKit Commit Bot

Comment 4 2016-03-25 10:28:40 PDT

Attachment 274916 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_frontend_dispatcher_header.py:46: [CppFrontendDispatcherHeaderGenerator.output_filename] Instance of 'CppFrontendDispatcherHeaderGenerator' has no 'protocol_name' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_frontend_dispatcher_header.py:53: [CppFrontendDispatcherHeaderGenerator.generate_output] Instance of 'CppFrontendDispatcherHeaderGenerator' has no 'protocol_name' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_alternate_backend_dispatcher_header.py:44: [CppAlternateBackendDispatcherHeaderGenerator.output_filename] Instance of 'CppAlternateBackendDispatcherHeaderGenerator' has no 'protocol_name' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_alternate_backend_dispatcher_header.py:48: [CppAlternateBackendDispatcherHeaderGenerator.generate_output] Instance of 'CppAlternateBackendDispatcherHeaderGenerator' has no 'protocol_name' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_backend_dispatcher_header.py:46: [CppBackendDispatcherHeaderGenerator.output_filename] Instance of 'CppBackendDispatcherHeaderGenerator' has no 'protocol_name' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_backend_dispatcher_header.py:53: [CppBackendDispatcherHeaderGenerator.generate_output] Instance of 'CppBackendDispatcherHeaderGenerator' has no 'protocol_name' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_protocol_types_header.py:46: [CppProtocolTypesHeaderGenerator.output_filename] Instance of 'CppProtocolTypesHeaderGenerator' has no 'protocol_name' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/cpp_generator.py:46: expected 2 blank lines, found 1 [pep8/E302] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/cpp_generator.py:51: [CppGenerator.protocol_name] Instance of 'CppGenerator' has no 'model' member [pylint/E1101] [5] Total errors found: 9 in 30 files If any of these errors are false positives, please file a bug against check-webkit-style.

Alex Christensen

Comment 5 2016-03-25 10:33:51 PDT

Comment on attachment 274916 [details] Proposed Fix pragma once changing some names around seems ok. r=me, but wait for ews Also, this could probably fix the need for my awful hack in http://trac.webkit.org/changeset/198659/trunk/Source/WebKit2/CMakeLists.txt

Blaze Burg

Comment 6 2016-03-25 10:50:53 PDT

(In reply to comment #5) > Comment on attachment 274916 [details] > Proposed Fix > > pragma once > changing some names around > seems ok. r=me, but wait for ews > Also, this could probably fix the need for my awful hack in > http://trac.webkit.org/changeset/198659/trunk/Source/WebKit2/CMakeLists.txt If EWS passes, I'll do a partial revert and land it locally. Otherwise I'll add the revert to the next EWS patch.

Blaze Burg

Comment 7 2016-03-25 11:18:51 PDT

Committed r198678: <http://trac.webkit.org/changeset/198678>

Note You need to log in before you can comment on or make changes to this bug.