Bug 155854

Summary: ES6: Implement IsRegExp function and use where needed in String.prototype.* methods
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, keith_miller, mark.lam, msaboff
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch
mark.lam: review+
patch
none
patch for landing none

Saam Barati
Reported 2016-03-24 14:45:31 PDT
https://tc39.github.io/ecma262/#sec-isregexp
Attachments
patch (12.07 KB, patch)
2016-03-24 15:19 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
patch (12.07 KB, patch)
2016-03-24 15:20 PDT, Saam Barati 		mark.lam: review+
DetailsFormatted DiffDiff
patch (13.48 KB, patch)
2016-03-24 15:24 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
patch for landing (13.48 KB, patch)
2016-03-24 15:29 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2016-03-24 15:19:02 PDT
Created attachment 274858 [details] patch
Saam Barati
Comment 2 2016-03-24 15:20:39 PDT
Created attachment 274859 [details] patch
Mark Lam
Comment 3 2016-03-24 15:23:23 PDT
Comment on attachment 274859 [details] patch r=me
Saam Barati
Comment 4 2016-03-24 15:24:04 PDT
Created attachment 274860 [details] patch
Saam Barati
Comment 5 2016-03-24 15:29:25 PDT
Created attachment 274861 [details] patch for landing
Saam Barati
Comment 6 2016-03-24 16:19:07 PDT
landed in: http://trac.webkit.org/changeset/198652
Darin Adler
Comment 7 2016-03-25 10:22:41 PDT
Comment on attachment 274861 [details] patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=274861&action=review > Source/JavaScriptCore/runtime/StringPrototype.cpp:1848 1) "cannot" is a single word, "can not" is incorrect. English is stranger than C++™. 2) We should figure out a consistent style for these error strings. A cleanup for the future. 3) Should this have a period or not? > Source/JavaScriptCore/runtime/StringPrototype.cpp:1884 > + return throwVMTypeError(exec, "Argument to String.prototype.endsWith can not be a RegExp."); Ditto.
Saam Barati
Comment 8 2016-03-25 11:01:53 PDT
(In reply to comment #7) > Comment on attachment 274861 [details] > patch for landing > > View in context: > https://bugs.webkit.org/attachment.cgi?id=274861&action=review > > > Source/JavaScriptCore/runtime/StringPrototype.cpp:1848 > > > 1) "cannot" is a single word, "can not" is incorrect. English is stranger > than C++™. > 2) We should figure out a consistent style for these error strings. A > cleanup for the future. > 3) Should this have a period or not? > > > Source/JavaScriptCore/runtime/StringPrototype.cpp:1884 > > + return throwVMTypeError(exec, "Argument to String.prototype.endsWith can not be a RegExp."); > > Ditto. Thanks. I will update these.
Saam Barati
Comment 9 2016-03-25 11:35:53 PDT
Big to fix grammar https://bugs.webkit.org/show_bug.cgi?id=155895
Note You need to log in before you can comment on or make changes to this bug.