Bug 155845

Summary: Fix internal iOS9 performance regression after r197572
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, benjamin, cdumez, cmarcelo, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Alex Christensen
Reported 2016-03-24 11:33:01 PDT
Fix internal iOS9 performance regression after r197572
Attachments
Patch (1.06 KB, patch)
2016-03-24 11:34 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (1.10 KB, patch)
2016-03-24 11:43 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2016-03-24 11:34:47 PDT
Created attachment 274847 [details] Patch
Chris Dumez
Comment 2 2016-03-24 11:37:38 PDT
rdar://problem/25144924
Chris Dumez
Comment 3 2016-03-24 11:38:27 PDT
Comment on attachment 274847 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=274847&action=review > Source/WTF/wtf/Platform.h:554 > +#if USE(APPLE_INTERNAL_SDK) && __IPHONE_OS_VERSION_MIN_REQUIRED <= 90000 how about 9.x ? You likely want to use < iOS10 instead.
Chris Dumez
Comment 4 2016-03-24 11:39:53 PDT
Comment on attachment 274847 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=274847&action=review >> Source/WTF/wtf/Platform.h:554 >> +#if USE(APPLE_INTERNAL_SDK) && __IPHONE_OS_VERSION_MIN_REQUIRED <= 90000 > > how about 9.x ? > > You likely want to use < iOS10 instead. Can this be just: if __IPHONE_OS_VERSION_MIN_REQUIRED < 100000 #define USE_CFNETWORK 1 #endif ?
Chris Dumez
Comment 5 2016-03-24 11:41:51 PDT
(In reply to comment #4) > Comment on attachment 274847 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=274847&action=review > > >> Source/WTF/wtf/Platform.h:554 > >> +#if USE(APPLE_INTERNAL_SDK) && __IPHONE_OS_VERSION_MIN_REQUIRED <= 90000 > > > > how about 9.x ? > > > > You likely want to use < iOS10 instead. > > Can this be just: > if __IPHONE_OS_VERSION_MIN_REQUIRED < 100000 > #define USE_CFNETWORK 1 > #endif > > ? Actually, previous we had USE(APPLE_INTERNAL_SDK) as condition so I guess we should use: if USE(APPLE_INTERNAL_SDK) && __IPHONE_OS_VERSION_MIN_REQUIRED < 100000 #define USE_CFNETWORK 1 #endif
Alex Christensen
Comment 6 2016-03-24 11:43:38 PDT
Created attachment 274848 [details] Patch
Chris Dumez
Comment 7 2016-03-24 11:49:59 PDT
Comment on attachment 274848 [details] Patch r=me, thanks.
Chris Dumez
Comment 8 2016-03-24 12:56:57 PDT
Comment on attachment 274848 [details] Patch Clearing flags on attachment: 274848 Committed r198641: <http://trac.webkit.org/changeset/198641>
Chris Dumez
Comment 9 2016-03-24 12:57:02 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.