| Summary: | Web Automation: Add commands to compute layout of an element | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Timothy Hatcher <timothy> | ||||
| Component: | Web Inspector | Assignee: | Timothy Hatcher <timothy> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bburg, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Local Build | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Timothy Hatcher
2016-03-24 10:10:42 PDT
Created attachment 274840 [details]
Patch
Comment on attachment 274840 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=274840&action=review r=me > Source/WebKit2/UIProcess/Automation/Automation.json:256 > + { "name": "useViewportCoordinates", "optional": true, "type": "boolean", "description": "If the result coordinates should be represented as viewport coordinates or not. Defaults to false, which is means coordinates should be represented as page coordinates." } Grammar: 'which is means' For the JSON protocol, I would prefer that this be non-optional and take an enum { PageCoordinates, ViewCoordinates }. It doesn't matter as much for the WK2 message. > Source/WebKit2/WebProcess/Automation/WebAutomationSessionProxy.cpp:415 > + String frameNotFoundErrorType = Inspector::Protocol::getEnumConstantValue(Inspector::Protocol::Automation::ErrorMessage::FrameNotFound); You can pull these error constants out to the top scope. |