Bug 155841 – Web Automation: Add commands to compute layout of an element

• Component: Web Inspector
• Status: RESOLVED FIXED

[Timothy Hatcher]

We need a rect and to be able to scroll the element into view first.

[Radar WebKit Bug Importer]

<rdar://problem/25340075>

[Timothy Hatcher]

Created attachment 274840 [details]
Patch

[Blaze Burg]

Comment on attachment 274840 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274840&action=review

r=me

> Source/WebKit2/UIProcess/Automation/Automation.json:256
> +                { "name": "useViewportCoordinates", "optional": true, "type": "boolean", "description": "If the result coordinates should be represented as viewport coordinates or not. Defaults to false, which is means coordinates should be represented as page coordinates." }

Grammar: 'which is means'

For the JSON protocol, I would prefer that this be non-optional and take an enum { PageCoordinates, ViewCoordinates }. It doesn't matter as much for the WK2 message.

> Source/WebKit2/WebProcess/Automation/WebAutomationSessionProxy.cpp:415
> +        String frameNotFoundErrorType = Inspector::Protocol::getEnumConstantValue(Inspector::Protocol::Automation::ErrorMessage::FrameNotFound);

You can pull these error constants out to the top scope.

[Timothy Hatcher]

https://trac.webkit.org/r198739