Bug 155840

Summary:

Determine architecture for running jsc stress tests on windows

Product:

WebKit

Reporter:

Bill Ming <mbbill>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, lforschler

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Bill Ming

Reported 2016-03-24 09:55:50 PDT

Currently run-jsc-stress-tests will throw an error saying unable to determine architecture when run on windows.

Attachments
Patch (2.00 KB, patch) 2016-03-24 09:58 PDT, Bill Ming	no flags	Details Formatted Diff Diff
Patch (2.00 KB, patch) 2016-03-24 19:44 PDT, Bill Ming	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Bill Ming

Comment 1 2016-03-24 09:58:51 PDT

Alex Christensen

Comment 2 2016-03-24 17:15:15 PDT

Comment on attachment 274839 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=274839&action=review Looks good to me otherwise. r- because this needs a small fix. > Tools/Scripts/run-jsc-stress-tests:360 > + data = f.read(4096) This is too much.

Bill Ming

Comment 3 2016-03-24 19:44:18 PDT

Alex Christensen

Comment 4 2016-03-24 21:26:23 PDT

Comment on attachment 274875 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=274875&action=review > Tools/Scripts/run-jsc-stress-tests:360 > + data = f.read(1024) I still think this could be smaller, but I doubt anyone would ever have an executable smaller than 1k. If they do, we can fix this.

WebKit Commit Bot

Comment 5 2016-03-24 22:14:18 PDT

WebKit Commit Bot

Comment 6 2016-03-24 22:14:22 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.