Bug 155827

Summary: webkit-patch failed to open pretty diff on Windows
Product: WebKit Reporter: Bill Ming <mbbill>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, glenn, lforschler, ossy
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Windows 10   
Attachments:
Description Flags
Patch
none
Patch none

Bill Ming
Reported 2016-03-23 19:55:39 PDT
file://%s % urllib.quote(pretty_diff_file.name) will not produce correct file url on windows. Should pathname2url instead.
Attachments
Patch (1.61 KB, patch)
2016-03-23 19:57 PDT, Bill Ming 		no flags
DetailsFormatted DiffDiff
Patch (1.61 KB, patch)
2016-03-24 00:22 PDT, Bill Ming 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Bill Ming
Comment 1 2016-03-23 19:57:00 PDT
Created attachment 274813 [details] Patch
WebKit Commit Bot
Comment 2 2016-03-23 22:16:58 PDT
Comment on attachment 274813 [details] Patch Clearing flags on attachment: 274813 Committed r198617: <http://trac.webkit.org/changeset/198617>
WebKit Commit Bot
Comment 3 2016-03-23 22:17:01 PDT
All reviewed patches have been landed. Closing bug.
Csaba Osztrogonác
Comment 4 2016-03-23 23:35:58 PDT
(In reply to comment #2) > Comment on attachment 274813 [details] > Patch > > Clearing flags on attachment: 274813 > > Committed r198617: <http://trac.webkit.org/changeset/198617> It broke 7 webkitpy tests.
Bill Ming
Comment 5 2016-03-23 23:37:51 PDT
I'll have a look
Bill Ming
Comment 6 2016-03-24 00:21:57 PDT
Reopening to attach new patch.
Bill Ming
Comment 7 2016-03-24 00:22:02 PDT
Created attachment 274824 [details] Patch
Bill Ming
Comment 8 2016-03-24 00:23:50 PDT
All 1452 tests passed
Bill Ming
Comment 9 2016-03-24 00:25:16 PDT
As the previous patch has already landed, shall I create a new patch for the test case fix?
Alex Christensen
Comment 10 2016-03-24 10:02:55 PDT
Comment on attachment 274824 [details] Patch Usually if something breaks tests, we revert it immediately and land a new patch that doesn't break any tests. In this case, I just landed your fix in http://trac.webkit.org/changeset/198628
Note You need to log in before you can comment on or make changes to this bug.