Bug 155802

Summary: [GTK] Web Inspector: Add new GTK+ icons for resources in large sizes (32px @ 1x/2x)
Product: WebKit Reporter: Matt Baker <mattbaker>
Component: Web InspectorAssignee: Fujii Hironori <Hironori.Fujii>
Status: RESOLVED FIXED    
Severity: Normal CC: agomez, aperez, bugs-noreply, cgarcia, commit-queue, graouts, Hironori.Fujii, inspector-bugzilla-changes, joepeck, mcatanzaro, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
screenshot of before and after this fix none

Description Matt Baker 2016-03-23 12:42:21 PDT
* SUMMARY
Add new GTK+ icons for resources in large sizes (32px @ 1x/2x). For now these only appear in the Quick Open dialog.

ClippingCSSLarge.png
ClippingCSSLarge@2x.png
ClippingGenericLarge.png
ClippingGenericLarge@2x.png
ClippingJSLarge.png
ClippingJSLarge@2x.png

DocumentCSSLarge.png
DocumentCSSLarge@2x.png
DocumentFontLarge.png
DocumentFontLarge@2x.png
DocumentGenericLarge.png
DocumentGenericLarge@2x.png
DocumentImageLarge.png
DocumentImageLarge@2x.png
DocumentJSLarge.png
DocumentJSLarge@2x.png
DocumentMarkupLarge.png
DocumentMarkupLarge@2x.png

See https://bugs.webkit.org/show_bug.cgi?id=155557.
Comment 1 Radar WebKit Bug Importer 2016-03-23 12:42:43 PDT
<rdar://problem/25320686>
Comment 2 Fujii Hironori 2017-05-10 23:28:24 PDT
Created attachment 309692 [details]
Patch
Comment 3 Fujii Hironori 2017-05-10 23:35:16 PDT
Created attachment 309694 [details]
screenshot of before and after this fix
Comment 4 Carlos Garcia Campos 2017-05-11 00:26:53 PDT
Comment on attachment 309692 [details]
Patch

Thanks!
Comment 5 WebKit Commit Bot 2017-05-11 00:56:19 PDT
Comment on attachment 309692 [details]
Patch

Clearing flags on attachment: 309692

Committed r216671: <http://trac.webkit.org/changeset/216671>
Comment 6 WebKit Commit Bot 2017-05-11 00:56:21 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Joseph Pecoraro 2017-05-11 10:54:53 PDT
Comment on attachment 309692 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309692&action=review

These look great!

> Source/WebInspectorUI/ChangeLog:28
> +        * UserInterface/Images/gtk/DocumentMarkupLarge.png: Added.
> +        * UserInterface/Images/gtk/DocumentMarkupLarge@2x.png: Added.

The "WorkerScriptLarge" and WebSocket images are pretty close to these. Those would be a natural next follow-up. See bug 164138.