Bug 155802

Summary: [GTK] Web Inspector: Add new GTK+ icons for resources in large sizes (32px @ 1x/2x)
Product: WebKit Reporter: Matt Baker <mattbaker>
Component: Web InspectorAssignee: Fujii Hironori <fujii.hironori>
Status: RESOLVED FIXED    
Severity: Normal CC: agomez, aperez, bugs-noreply, cgarcia, commit-queue, fujii.hironori, graouts, inspector-bugzilla-changes, joepeck, mcatanzaro, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
screenshot of before and after this fix none

Matt Baker
Reported 2016-03-23 12:42:21 PDT
* SUMMARY Add new GTK+ icons for resources in large sizes (32px @ 1x/2x). For now these only appear in the Quick Open dialog. ClippingCSSLarge.png ClippingCSSLarge@2x.png ClippingGenericLarge.png ClippingGenericLarge@2x.png ClippingJSLarge.png ClippingJSLarge@2x.png DocumentCSSLarge.png DocumentCSSLarge@2x.png DocumentFontLarge.png DocumentFontLarge@2x.png DocumentGenericLarge.png DocumentGenericLarge@2x.png DocumentImageLarge.png DocumentImageLarge@2x.png DocumentJSLarge.png DocumentJSLarge@2x.png DocumentMarkupLarge.png DocumentMarkupLarge@2x.png See https://bugs.webkit.org/show_bug.cgi?id=155557.
Attachments
Patch (101.80 KB, patch)
2017-05-10 23:28 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
screenshot of before and after this fix (115.52 KB, image/png)
2017-05-10 23:35 PDT, Fujii Hironori 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-03-23 12:42:43 PDT
<rdar://problem/25320686>
Fujii Hironori
Comment 2 2017-05-10 23:28:24 PDT
Created attachment 309692 [details] Patch
Fujii Hironori
Comment 3 2017-05-10 23:35:16 PDT
Created attachment 309694 [details] screenshot of before and after this fix
Carlos Garcia Campos
Comment 4 2017-05-11 00:26:53 PDT
Comment on attachment 309692 [details] Patch Thanks!
WebKit Commit Bot
Comment 5 2017-05-11 00:56:19 PDT
Comment on attachment 309692 [details] Patch Clearing flags on attachment: 309692 Committed r216671: <http://trac.webkit.org/changeset/216671>
WebKit Commit Bot
Comment 6 2017-05-11 00:56:21 PDT
All reviewed patches have been landed. Closing bug.
Joseph Pecoraro
Comment 7 2017-05-11 10:54:53 PDT
Comment on attachment 309692 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=309692&action=review These look great! > Source/WebInspectorUI/ChangeLog:28 > + * UserInterface/Images/gtk/DocumentMarkupLarge.png: Added. > + * UserInterface/Images/gtk/DocumentMarkupLarge@2x.png: Added. The "WorkerScriptLarge" and WebSocket images are pretty close to these. Those would be a natural next follow-up. See bug 164138.
Note You need to log in before you can comment on or make changes to this bug.