| Summary: | Remove firing assertion when redirecting | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | ||||||||
| Priority: | P2 | ||||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Alex Christensen
2016-03-23 11:58:01 PDT
Created attachment 274766 [details]
Patch
Comment on attachment 274766 [details] Patch Attachment 274766 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/1027483 New failing tests: imported/w3c/web-platform-tests/streams/readable-streams/general.https.html Created attachment 274769 [details]
Archive of layout-test-results from ews113 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113 Port: mac-yosemite Platform: Mac OS X 10.10.5
This code is not even compiled on Yosemite. failure unrelated. Comment on attachment 274766 [details]
Patch
You should actually figure out what's going on here, because you seem to agree that we really shouldn't be getting here with null networkDataTask, making the assertion not irrelevant.
Comment on attachment 274766 [details]
Patch
The load is being "canceled" by the WebProcess, and the NetworkLoad and NetworkDataTask are being destroyed. With NSURLConnection, we stopped getting delegate callbacks once the delegate is destroyed, with NSURLSession we continue getting delegate callbacks because the session's delegate is not destroyed after each load. I think this is correct.
Comment on attachment 274766 [details]
Patch
You should remove the assert in didReceiveChallenge as well (and convert it to call NSURLSessionAuthChallengeCancelAuthenticationChallenge instead of NSURLSessionAuthChallengePerformDefaultHandling).
|