Bug 155792 – Basic implementation of mpadded

• Component: MathML
• Status: RESOLVED FIXED

[Frédéric Wang (:fredw)]

First step to implement mpadded without the pseudo-units values.

[Frédéric Wang (:fredw)]

Created attachment 274750 [details]
Patch

[Frédéric Wang (:fredw)]

Created attachment 277386 [details]
Patch

[Frédéric Wang (:fredw)]

Created attachment 282060 [details]
Patch

[Build Bot]

Comment on attachment 282060 [details]
Patch

Attachment 282060 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1567030

New failing tests:
mathml/presentation/inferred-mrow-stretchy.html

[Build Bot]

Created attachment 282063 [details]
Archive of layout-test-results from ews103 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 282060 [details]
Patch

Attachment 282060 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1567034

New failing tests:
mathml/presentation/inferred-mrow-stretchy.html

[Build Bot]

Created attachment 282065 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 282060 [details]
Patch

Attachment 282060 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1567035

New failing tests:
mathml/presentation/inferred-mrow-stretchy.html

[Build Bot]

Created attachment 282067 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.4

[Build Bot]

Comment on attachment 282060 [details]
Patch

Attachment 282060 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1567045

New failing tests:
mathml/presentation/inferred-mrow-stretchy.html

[Build Bot]

Created attachment 282069 [details]
Archive of layout-test-results from ews114 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Frédéric Wang (:fredw)]

Created attachment 283057 [details]
Patch

Updating patch...

[Brent Fulgham]

Comment on attachment 283057 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=283057&action=review

r=me, but please correct the minor issues I pointed out.

> Source/WebCore/rendering/mathml/RenderMathMLPadded.cpp:39
> +    , m_ascent(0)

I don't think this explicit initialization is needed, since the default constructor for LayoutUnit will initialize to zero.

> Source/WebCore/rendering/mathml/RenderMathMLPadded.cpp:51
> +    // We parse it using our the preferred width of the content as the default value.

This reads a little strangely. I think it might need to be "// We parse it using the preferred width of the content as its default value."

> Source/WebCore/rendering/mathml/RenderMathMLPadded.cpp:123
> +    return Optional<int>(static_cast<int>(lroundf(m_ascent)));

We should use:

std::lround(m_ascent)

You might need to #include <cmath>

> Source/WebCore/rendering/mathml/RenderMathMLPadded.h:27
> +#define RenderMathMLPadded_h

#pragma once

[Frédéric Wang (:fredw)]

Committed r202962: <http://trac.webkit.org/changeset/202962>