Bug 155788

Summary: [css-grid] Remove unneeded lines in offsetAndBreadthForPositionedChild()
Product: WebKit Reporter: Manuel Rego Casasnovas <rego>
Component: Layout and RenderingAssignee: Manuel Rego Casasnovas <rego>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, jfernandez, kondapallykalyan, rego, simon.fraser, svillar
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 60731    
Attachments:
Description Flags
Patch
none
Patch for landing none

Description Manuel Rego Casasnovas 2016-03-23 04:42:08 PDT 
[css-grid] Remove unneeded lines in offsetAndBreadthForPositionedChild()
Comment 1 Manuel Rego Casasnovas 2016-03-23 04:44:19 PDT 
Created attachment 274744 [details]
Patch
Comment 2 Sergio Villar Senin 2016-03-28 02:27:52 PDT 
Comment on attachment 274744 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274744&action=review

> Source/WebCore/rendering/RenderGrid.cpp:1520
> +    LayoutUnit start = startIsAuto ? LayoutUnit() : isRowAxis ?  m_columnPositions[startLine] : m_rowPositions[startLine];

Mind adding parens here too. Otherwise it's very difficult to read.
Comment 3 Manuel Rego Casasnovas 2016-03-28 03:34:28 PDT 
Created attachment 275020 [details]
Patch for landing
Comment 4 Manuel Rego Casasnovas 2016-03-28 03:35:06 PDT 
Thanks for the review.

(In reply to comment #2)
> Comment on attachment 274744 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=274744&action=review
> 
> > Source/WebCore/rendering/RenderGrid.cpp:1520
> > +    LayoutUnit start = startIsAuto ? LayoutUnit() : isRowAxis ?  m_columnPositions[startLine] : m_rowPositions[startLine];
> 
> Mind adding parens here too. Otherwise it's very difficult to read.

Done.
Comment 5 WebKit Commit Bot 2016-03-28 04:22:46 PDT 
Comment on attachment 275020 [details]
Patch for landing

Clearing flags on attachment: 275020

Committed r198732: <http://trac.webkit.org/changeset/198732>
Comment 6 WebKit Commit Bot 2016-03-28 04:22:51 PDT 
All reviewed patches have been landed.  Closing bug.