Bug 155788 - [css-grid] Remove unneeded lines in offsetAndBreadthForPositionedChild()
Summary: [css-grid] Remove unneeded lines in offsetAndBreadthForPositionedChild()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Manuel Rego Casasnovas
URL:
Keywords:
Depends on:
Blocks: 60731
  Show dependency tree / graph
 
Reported: 2016-03-23 04:42 PDT by Manuel Rego Casasnovas
Modified: 2016-03-28 04:22 PDT (History)
8 users (show)

See Also:

Attachments
Patch (2.11 KB, patch)
2016-03-23 04:44 PDT, Manuel Rego Casasnovas 		no flags Details | Formatted Diff | Diff
Patch for landing (2.12 KB, patch)
2016-03-28 03:34 PDT, Manuel Rego Casasnovas 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Manuel Rego Casasnovas 2016-03-23 04:42:08 PDT 
[css-grid] Remove unneeded lines in offsetAndBreadthForPositionedChild()
Comment 1 Manuel Rego Casasnovas 2016-03-23 04:44:19 PDT 
Created attachment 274744 [details]
Patch
Comment 2 Sergio Villar Senin 2016-03-28 02:27:52 PDT 
Comment on attachment 274744 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274744&action=review

> Source/WebCore/rendering/RenderGrid.cpp:1520
> +    LayoutUnit start = startIsAuto ? LayoutUnit() : isRowAxis ?  m_columnPositions[startLine] : m_rowPositions[startLine];

Mind adding parens here too. Otherwise it's very difficult to read.
Comment 3 Manuel Rego Casasnovas 2016-03-28 03:34:28 PDT 
Created attachment 275020 [details]
Patch for landing
Comment 4 Manuel Rego Casasnovas 2016-03-28 03:35:06 PDT 
Thanks for the review.

(In reply to comment #2)
> Comment on attachment 274744 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=274744&action=review
> 
> > Source/WebCore/rendering/RenderGrid.cpp:1520
> > +    LayoutUnit start = startIsAuto ? LayoutUnit() : isRowAxis ?  m_columnPositions[startLine] : m_rowPositions[startLine];
> 
> Mind adding parens here too. Otherwise it's very difficult to read.

Done.
Comment 5 WebKit Commit Bot 2016-03-28 04:22:46 PDT 
Comment on attachment 275020 [details]
Patch for landing

Clearing flags on attachment: 275020

Committed r198732: <http://trac.webkit.org/changeset/198732>
Comment 6 WebKit Commit Bot 2016-03-28 04:22:51 PDT 
All reviewed patches have been landed.  Closing bug.