Bug 155787

Summary: Share style by sharing RenderStyle substructures not the object itself
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kling, kondapallykalyan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch
kling: review+
patch none

Antti Koivisto
Reported 2016-03-23 04:36:19 PDT
Current approach where we share RenderStyle objects between elements leads to lot of awkward and bug-prone code. Most of the RenderStyle consists of shareable substructures. It is better to just share those.
Attachments
patch (9.55 KB, patch)
2016-03-23 04:38 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (10.35 KB, patch)
2016-03-23 05:49 PDT, Antti Koivisto 		kling: review+
DetailsFormatted DiffDiff
patch (10.48 KB, patch)
2016-03-23 06:44 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2016-03-23 04:38:45 PDT
Created attachment 274743 [details] patch
Antti Koivisto
Comment 2 2016-03-23 05:49:42 PDT
Created attachment 274746 [details] patch
Andreas Kling
Comment 3 2016-03-23 06:00:12 PDT
Comment on attachment 274746 [details] patch r=me, let's hope this doesn't regress anything, it's so much cleaner.
Antti Koivisto
Comment 4 2016-03-23 06:44:11 PDT
Created attachment 274748 [details] patch
Antti Koivisto
Comment 5 2016-03-23 07:30:25 PDT
https://trac.webkit.org/r198584
Note You need to log in before you can comment on or make changes to this bug.