Bug 155763

Summary: Web Inspector: REGRESSION: Shift + Click on record button should create a new recording
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix
none
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2016-03-22 12:11:04 PDT
* SUMMARY REGRESSION: Shift + Click on record button should create a new recording. * STEPS TO REPRODUCE 1. Inspect this page 2. Start + stop a Timeline recording 3. Shift + Click the record button => Expected a new recording, instead it continued the current recording
Attachments
[PATCH] Proposed Fix (2.30 KB, patch)
2016-03-22 12:13 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
[PATCH] Proposed Fix (1.51 KB, patch)
2016-03-22 13:18 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-03-22 12:11:35 PDT
<rdar://problem/25296624>
Joseph Pecoraro
Comment 2 2016-03-22 12:13:13 PDT
Created attachment 274673 [details] [PATCH] Proposed Fix
Timothy Hatcher
Comment 3 2016-03-22 12:26:31 PDT
Comment on attachment 274673 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=274673&action=review > Source/WebInspectorUI/UserInterface/Views/TimelineTabContentView.js:398 > + this._toggleRecording(domEvent.shiftKey); window.event.shiftKey and you can get rid of the userData
Joseph Pecoraro
Comment 4 2016-03-22 13:18:24 PDT
Created attachment 274677 [details] [PATCH] Proposed Fix
WebKit Commit Bot
Comment 5 2016-03-22 14:28:45 PDT
Comment on attachment 274677 [details] [PATCH] Proposed Fix Clearing flags on attachment: 274677 Committed r198552: <http://trac.webkit.org/changeset/198552>
WebKit Commit Bot
Comment 6 2016-03-22 14:28:49 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.