Bug 155763 - Web Inspector: REGRESSION: Shift + Click on record button should create a new recording
Summary: Web Inspector: REGRESSION: Shift + Click on record button should create a new...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-03-22 12:11 PDT by Joseph Pecoraro
Modified: 2016-03-22 14:28 PDT (History)
8 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (2.30 KB, patch)
2016-03-22 12:13 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff
[PATCH] Proposed Fix (1.51 KB, patch)
2016-03-22 13:18 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-03-22 12:11:04 PDT
* SUMMARY
REGRESSION: Shift + Click on record button should create a new recording.

* STEPS TO REPRODUCE
1. Inspect this page
2. Start + stop a Timeline recording
3. Shift + Click the record button
  => Expected a new recording, instead it continued the current recording
Comment 1 Radar WebKit Bug Importer 2016-03-22 12:11:35 PDT
<rdar://problem/25296624>
Comment 2 Joseph Pecoraro 2016-03-22 12:13:13 PDT
Created attachment 274673 [details]
[PATCH] Proposed Fix
Comment 3 Timothy Hatcher 2016-03-22 12:26:31 PDT
Comment on attachment 274673 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=274673&action=review

> Source/WebInspectorUI/UserInterface/Views/TimelineTabContentView.js:398
> +        this._toggleRecording(domEvent.shiftKey);

window.event.shiftKey and you can get rid of the userData
Comment 4 Joseph Pecoraro 2016-03-22 13:18:24 PDT
Created attachment 274677 [details]
[PATCH] Proposed Fix
Comment 5 WebKit Commit Bot 2016-03-22 14:28:45 PDT
Comment on attachment 274677 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 274677

Committed r198552: <http://trac.webkit.org/changeset/198552>
Comment 6 WebKit Commit Bot 2016-03-22 14:28:49 PDT
All reviewed patches have been landed.  Closing bug.