Bug 155752

Summary:

Web Inspector: String double quoting in the console and elsewhere needs to escape backslash too

Product:

WebKit

Reporter:

Timothy Hatcher <timothy>

Component:

Web Inspector

Assignee:

Timothy Hatcher <timothy>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	joepeck: review+, commit-queue: commit-queue-
Patch for Landing	commit-queue: commit-queue-

Timothy Hatcher

Reported 2016-03-22 10:11:31 PDT

We need to escape backslash to be correct.

Attachments
Patch (2.73 KB, patch) 2016-03-22 10:15 PDT, Timothy Hatcher	joepeck: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
Patch for Landing (2.37 KB, patch) 2016-03-22 17:00 PDT, Timothy Hatcher	commit-queue: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2016-03-22 10:12:03 PDT

<rdar://problem/25293141>

Timothy Hatcher

Comment 2 2016-03-22 10:15:13 PDT

Created attachment 274658 [details] Patch

Joseph Pecoraro

Comment 3 2016-03-22 13:52:10 PDT

Comment on attachment 274658 [details] Patch Nice. Should we just use JSON.stringify(str)? We could also test this adding a LayoutTests/inspector/unit-tests/utilities.html.

WebKit Commit Bot

Comment 4 2016-03-22 16:03:09 PDT

Comment on attachment 274658 [details] Patch Rejecting attachment 274658 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 274658, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebInspectorUI/ChangeLog contains OOPS!. Full output: http://webkit-queues.webkit.org/results/1022960

Timothy Hatcher

Comment 5 2016-03-22 17:00:10 PDT

Created attachment 274704 [details] Patch for Landing

WebKit Commit Bot

Comment 6 2016-03-22 17:20:20 PDT

Comment on attachment 274704 [details] Patch for Landing Rejecting attachment 274704 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 274704, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: '/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Parsed 3 diffs from patch file(s). patching file Source/WebInspectorUI/ChangeLog patch: **** unexpected end of file in patch patching file Source/WebInspectorUI/UserInterface/Base/Utilities.js patching file Source/WebInspectorUI/UserInterface/Views/FormattedValue.js Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/1023235

Timothy Hatcher

Comment 7 2016-03-23 08:55:18 PDT

https://trac.webkit.org/r198585

Note You need to log in before you can comment on or make changes to this bug.