Bug 155752 - Web Inspector: String double quoting in the console and elsewhere needs to escape backslash too
Summary: Web Inspector: String double quoting in the console and elsewhere needs to es...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-03-22 10:11 PDT by Timothy Hatcher
Modified: 2016-03-23 08:55 PDT (History)
8 users (show)

See Also:


Attachments
Patch (2.73 KB, patch)
2016-03-22 10:15 PDT, Timothy Hatcher
joepeck: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
Patch for Landing (2.37 KB, patch)
2016-03-22 17:00 PDT, Timothy Hatcher
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2016-03-22 10:11:31 PDT
We need to escape backslash to be correct.
Comment 1 Radar WebKit Bug Importer 2016-03-22 10:12:03 PDT
<rdar://problem/25293141>
Comment 2 Timothy Hatcher 2016-03-22 10:15:13 PDT
Created attachment 274658 [details]
Patch
Comment 3 Joseph Pecoraro 2016-03-22 13:52:10 PDT
Comment on attachment 274658 [details]
Patch

Nice. Should we just use JSON.stringify(str)?

We could also test this adding a LayoutTests/inspector/unit-tests/utilities.html.
Comment 4 WebKit Commit Bot 2016-03-22 16:03:09 PDT
Comment on attachment 274658 [details]
Patch

Rejecting attachment 274658 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 274658, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebInspectorUI/ChangeLog contains OOPS!.

Full output: http://webkit-queues.webkit.org/results/1022960
Comment 5 Timothy Hatcher 2016-03-22 17:00:10 PDT
Created attachment 274704 [details]
Patch for Landing
Comment 6 WebKit Commit Bot 2016-03-22 17:20:20 PDT
Comment on attachment 274704 [details]
Patch for Landing

Rejecting attachment 274704 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 274704, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Parsed 3 diffs from patch file(s).
patching file Source/WebInspectorUI/ChangeLog
patch: **** unexpected end of file in patch
patching file Source/WebInspectorUI/UserInterface/Base/Utilities.js
patching file Source/WebInspectorUI/UserInterface/Views/FormattedValue.js

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/1023235
Comment 7 Timothy Hatcher 2016-03-23 08:55:18 PDT
https://trac.webkit.org/r198585