Bug 155698

Summary:

Fixed compilation with GCC 4.8.

Product:

WebKit

Reporter:

Konstantin Tokarev <annulen>

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, benjamin, commit-queue, keith_miller, mark.lam, msaboff, saam

Priority:

Version:

WebKit Local Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description Konstantin Tokarev 2016-03-20 10:05:17 PDT

GCC 4.8 does not allow aggregate initialization for type with deleted constructor, see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=52707.

Comment 1 Konstantin Tokarev 2016-03-20 10:08:30 PDT

Created attachment 274541 [details]
Patch

Comment 2 Alexey Proskuryakov 2016-03-20 22:34:26 PDT

Comment on attachment 274541 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274541&action=review

> Source/JavaScriptCore/dfg/DFGCSEPhase.cpp:59
> +    ImpureDataSlot(HeapLocation _key, LazyNode _value, unsigned _hash)
> +        : key(_key), value(_value), hash(_hash)

There is no need to add leading underscores here. The following is valid C++ that implements the same behavior:

    ImpureDataSlot(HeapLocation key, LazyNode value, unsigned hash)
        : key(key), value(value), hash(hash)

Comment 3 Konstantin Tokarev 2016-03-21 06:21:27 PDT

Created attachment 274583 [details]
Patch

Comment 4 WebKit Commit Bot 2016-03-21 10:17:32 PDT

Comment on attachment 274583 [details]
Patch

Clearing flags on attachment: 274583

Committed r198490: <http://trac.webkit.org/changeset/198490>

Comment 5 WebKit Commit Bot 2016-03-21 10:17:36 PDT

All reviewed patches have been landed.  Closing bug.