Bug 155698

Summary: Fixed compilation with GCC 4.8.
Product: WebKit Reporter: Konstantin Tokarev <annulen>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, benjamin, commit-queue, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Konstantin Tokarev
Reported 2016-03-20 10:05:17 PDT
GCC 4.8 does not allow aggregate initialization for type with deleted constructor, see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=52707.
Attachments
Patch (1.46 KB, patch)
2016-03-20 10:08 PDT, Konstantin Tokarev 		no flags
DetailsFormatted DiffDiff
Patch (1.46 KB, patch)
2016-03-21 06:21 PDT, Konstantin Tokarev 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Konstantin Tokarev
Comment 1 2016-03-20 10:08:30 PDT
Created attachment 274541 [details] Patch
Alexey Proskuryakov
Comment 2 2016-03-20 22:34:26 PDT
Comment on attachment 274541 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=274541&action=review > Source/JavaScriptCore/dfg/DFGCSEPhase.cpp:59 > + ImpureDataSlot(HeapLocation _key, LazyNode _value, unsigned _hash) > + : key(_key), value(_value), hash(_hash) There is no need to add leading underscores here. The following is valid C++ that implements the same behavior: ImpureDataSlot(HeapLocation key, LazyNode value, unsigned hash) : key(key), value(value), hash(hash)
Konstantin Tokarev
Comment 3 2016-03-21 06:21:27 PDT
Created attachment 274583 [details] Patch
WebKit Commit Bot
Comment 4 2016-03-21 10:17:32 PDT
Comment on attachment 274583 [details] Patch Clearing flags on attachment: 274583 Committed r198490: <http://trac.webkit.org/changeset/198490>
WebKit Commit Bot
Comment 5 2016-03-21 10:17:36 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.