Bug 155691

Summary: Web Inspector: protocol generator should generate C++ string-to-enum helper functions
Product: WebKit Reporter: BJ Burg <bburg>
Component: Web InspectorAssignee: BJ Burg <bburg>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, keith_miller, mark.lam, mattbaker, msaboff, nvasilyev, saam, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 147067    
Attachments:
Description Flags
Patch timothy: review+

Description BJ Burg 2016-03-19 15:33:32 PDT
.
Comment 1 Radar WebKit Bug Importer 2016-03-19 15:36:34 PDT
<rdar://problem/25258078>
Comment 2 BJ Burg 2016-03-20 14:01:21 PDT
Created attachment 274547 [details]
Patch
Comment 3 WebKit Commit Bot 2016-03-20 14:03:22 PDT
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
Comment 4 WebKit Commit Bot 2016-03-20 14:03:29 PDT
Attachment 274547 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_protocol_types_header.py:373:  [CppProtocolTypesHeaderGenerator._generate_declarations_for_enum_conversion_methods] Instance of 'CppProtocolTypesHeaderGenerator' has no 'domains_to_generate' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_protocol_types_header.py:385:  [CppProtocolTypesHeaderGenerator._generate_declarations_for_enum_conversion_methods] Instance of 'CppProtocolTypesHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_protocol_types_header.py:400:  [CppProtocolTypesHeaderGenerator._generate_declarations_for_enum_conversion_methods] Instance of 'CppProtocolTypesHeaderGenerator' has no 'wrap_with_guard_for_domain' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_protocol_types_implementation.py:143:  [CppProtocolTypesImplementationGenerator._generate_enum_conversion_methods_for_domain] Instance of 'CppProtocolTypesImplementationGenerator' has no 'wrap_with_guard_for_domain' member  [pylint/E1101] [5]
Total errors found: 4 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 BJ Burg 2016-03-28 11:21:08 PDT
Committed r198752: <http://trac.webkit.org/changeset/198752>