Bug 155691 - Web Inspector: protocol generator should generate C++ string-to-enum helper functions
Summary: Web Inspector: protocol generator should generate C++ string-to-enum helper f...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: BJ Burg
Keywords: InRadar
Depends on:
Blocks: InspectorProtocol
  Show dependency treegraph
Reported: 2016-03-19 15:33 PDT by BJ Burg
Modified: 2016-03-28 11:21 PDT (History)
12 users (show)

See Also:

Patch (139.59 KB, patch)
2016-03-20 14:01 PDT, BJ Burg
timothy: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2016-03-19 15:33:32 PDT
Comment 1 Radar WebKit Bug Importer 2016-03-19 15:36:34 PDT
Comment 2 BJ Burg 2016-03-20 14:01:21 PDT
Created attachment 274547 [details]
Comment 3 WebKit Commit Bot 2016-03-20 14:03:22 PDT
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
Comment 4 WebKit Commit Bot 2016-03-20 14:03:29 PDT
Attachment 274547 [details] did not pass style-queue:

ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_protocol_types_header.py:373:  [CppProtocolTypesHeaderGenerator._generate_declarations_for_enum_conversion_methods] Instance of 'CppProtocolTypesHeaderGenerator' has no 'domains_to_generate' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_protocol_types_header.py:385:  [CppProtocolTypesHeaderGenerator._generate_declarations_for_enum_conversion_methods] Instance of 'CppProtocolTypesHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_protocol_types_header.py:400:  [CppProtocolTypesHeaderGenerator._generate_declarations_for_enum_conversion_methods] Instance of 'CppProtocolTypesHeaderGenerator' has no 'wrap_with_guard_for_domain' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_protocol_types_implementation.py:143:  [CppProtocolTypesImplementationGenerator._generate_enum_conversion_methods_for_domain] Instance of 'CppProtocolTypesImplementationGenerator' has no 'wrap_with_guard_for_domain' member  [pylint/E1101] [5]
Total errors found: 4 in 18 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 BJ Burg 2016-03-28 11:21:08 PDT
Committed r198752: <http://trac.webkit.org/changeset/198752>